Conversation
…b8 (#2799) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
…98 (#2801) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
…41 (#2802) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co>
…46 (#2805) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
jedrazb
approved these changes
Sep 10, 2024
Contributor
jedrazb
left a comment
jedrazb
left a comment
There was a problem hiding this comment.
You just rebased on main rather than backporting manually right?
artem-shelkovnikov
approved these changes
Sep 10, 2024
Member
Author
I went to the "pull requests" tab, and compared |
Member
|
We'll lose some history, unfortunately, but might not be too important |
Member
Author
|
We shouldn't have lost any history. All the commits should still be there, and still link to their PRs. Right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is still on 8.16, as #2800 has not yet been able to build. But DRAs for 8.16 are being built now from 8.x branches, not main branches. We need to backport everything.
I'm going to mass-backport this, then set up main to auto-backport to 8.x until we can merge the 9.0 version bump PR.