Allow connectors to sync content into alias #2796
Merged
artem-shelkovnikov merged 13 commits intomainfrom Sep 9, 2024
Merged
Conversation
jedrazb
reviewed
Sep 6, 2024
Contributor
jedrazb
left a comment
jedrazb
left a comment
There was a problem hiding this comment.
LGTM. My main concern is that the fact we support both aliases and indexes is somewhat hidden in the fine print of our codebase.
Could we add explicit logs to indicate when we’re accessing an index via an alias and when we’re not? I’m just worried about a situation where the index-alias relationship gets messed up, and it’s hard to tell just by looking at the logs.
Should we log something in extract_index_or_alias that we detected alias relationship?
jedrazb
previously approved these changes
Sep 6, 2024
jedrazb
approved these changes
Sep 9, 2024
💔 Failed to create backport PR(s)The backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
seanstory
added a commit
that referenced
this pull request
Sep 13, 2024
use same format as Agent use dot instead of plus make release pipeline update and commit and tag version fix script path Bumping version from 0.0.1 to 0.0.1+build202409091445 reset version Add versionfile restoration to pipeline Bumping version from 0.0.1 to 0.0.1+build202409091807 reset version Ensure restore version script runs Bumping version from 0.0.1 to 0.0.1+build202409091817 reset version use the right restore script Bumping version from 0.0.1 to 0.0.1+build202409091830 Restoring version from 0.0.1+build202409091830 to 0.0.1 add version math Docker test should use docker tag version Autoformat Bumping version from 0.0.1 to 0.0.0+build202409091853 make sure we're setting the version Restoring version from 0.0.0+build202409091853 to 0.0.1 checkout the branch before making changes Bumping version from 0.0.1 to 0.0.0+build202409091914 Restoring version from 0.0.-1+build202409091914 to 0.0.1 Calculate release version from orig version Bumping version from 0.0.1 to 0.0.0+build202409091932 Restoring version from 0.0.0+build202409091932 to 0.0.1 escape pluses Bumping version from 0.0.1 to 0.0.0+build202409092020 Restoring version from 0.0.0+build202409092020 to 0.0.1 Restore gates for maintenance branch releasing Update docs for manual releasing Allow connectors to sync content into alias (#2796) Config option to disable connector secrets for native connectors (#2808) Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co> Update docker.elastic.co/wolfi/python:3.11-dev Docker digest to 088b946 (#2805) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Return back connectors/sources/__init__.py (#2810) Add missing __init__.py files (#2811) Get 8.x branch set up (#2813)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/elastic/search-team/issues/8228
We need to make connectors work with aliases. This PR takes a step forward this without backwards compatibility problems.
What it does is: if you attach connector to an alias of an index, connector will be able to sync data through the alias.
For now it's not possible to do it in UI at all - it needs to be done via Dev Tools or CLI to make it function, so for end user nothing changes yet.
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)