Revert default python to python3#2748
Merged
artem-shelkovnikov merged 1 commit intomainfrom Aug 14, 2024
Merged
Conversation
efegurkan
approved these changes
Aug 14, 2024
💔 Failed to create backport PR(s)The backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #2734 (review):
This was not a backwards-compatible change, and it did not work well for me when I was testing -
pythonalias always led to system Python.But it looks, like it just should. If CI is green, then I was wrong and we can safely keep the old
python3command work -python3should be correctly handled bypyenvSome context on
pythonvspython3: https://stackoverflow.com/questions/67550189/i-dont-have-python-but-i-have-python3