Make connectors work with python 3.10 and 3.11#2734
Make connectors work with python 3.10 and 3.11#2734artem-shelkovnikov merged 70 commits intomainfrom
Conversation
|
Holding off on review while the build is red, but holler when this is ready 🤞 |
It's just a random blip from CI not being able to start Elasticsearch, feel free to review :) |
seanstory
left a comment
There was a problem hiding this comment.
few comments/questions, but looks pretty straightforward, honestly. Nice work!
I kicked off a nightly, just for a double check: https://buildkite.com/elastic/connectors-nightly/builds/2404
seanstory
left a comment
There was a problem hiding this comment.
also, realized that 3.12 had slipped through in a few places
💔 Failed to create backport PR(s)The backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
| @@ -1,6 +1,6 @@ | |||
| .PHONY: test lint autoformat run ftest install release docker-build docker-run docker-push | |||
|
|
|||
| PYTHON=python3.10 | |||
There was a problem hiding this comment.
this change requires your setup to have an alias for python, in my machine I didn't had that and to make it work I have to do PYTHON=python3 make install
Is this an issue ? If no do we want to mention it in somewhere?
There was a problem hiding this comment.
Part of #2672
This PR makes connectors work with 3.10 and 3.11 version of Python. 3.12 is not supported yet because of some deprecations for
datetimepackage that we need to handle: https://blog.miguelgrinberg.com/post/it-s-time-for-a-change-datetime-utcnow-is-now-deprecated. Once it's handled, adding 3.12 to matrix is gonna be trivial.CI image was updated to make it work, here's the CI image script: https://github.com/elastic/ci-agent-images/blob/main/vm-images/enterprise-search/scripts/connectors-python/install-deps.sh
Link to nightlies using this branch: https://buildkite.com/elastic/connectors-nightly/builds/2402
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Release Note
Now it's possible to run connectors with Python 3.11 as well as Python 3.10