Use standard k8s labels and helm labels on ECK Operator pod

[naemono]

Picking back up #8278 .
Resolves #8584

This sets some common labels on the ECK operator pod when installed via Helm:

# with change
❯ kc get pod -n elastic-system elastic-operator-0 -o yaml | yq '.metadata.labels'
app.kubernetes.io/instance: elastic-operator
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: elastic-operator
app.kubernetes.io/version: 3.2.0-SNAPSHOT
apps.kubernetes.io/pod-index: "0"
controller-revision-hash: elastic-operator-66cb484647
helm.sh/chart: eck-operator-3.2.0-SNAPSHOT
statefulset.kubernetes.io/pod-name: elastic-operator-0

# without change
❯ kc get pod -n elastic-system elastic-operator-0 -o yaml | yq '.metadata.labels'
app.kubernetes.io/instance: elastic-operator
app.kubernetes.io/name: elastic-operator
apps.kubernetes.io/pod-index: "0"
controller-revision-hash: elastic-operator-7b8ff75c49
statefulset.kubernetes.io/pod-name: elastic-operator-0

It avoids the previous behavior in #8278 where they are also included in generation:

❯ make generate > /dev/null 2>&1 && cat config/operator.yaml | grep -i helm
# no output

[prodsecmachine]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

[Copilot]

Pull Request Overview

This PR implements standard Kubernetes and Helm labels on ECK operator pods when installed via Helm, while avoiding their inclusion in generated manifests. The change ensures that Helm-managed pods receive proper metadata for better observability and management.

• Adds conditional logic to include full labels (including Helm metadata) on pods only when not in manifest generation mode
• Updates test coverage to verify both StatefulSet and pod template labels are correctly applied
• Maintains backward compatibility by preserving existing behavior during manifest generation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
deploy/eck-operator/templates/statefulset.yaml	Adds conditional logic to apply full labels including Helm metadata to pod templates
deploy/eck-operator/templates/tests/statefulset_test.yaml	Adds test case to verify pod template labels are correctly applied with custom podLabels

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[barkbay]

LGTM
(please set the version label on this PR before merging)

[barkbay]

Is it a fix for #8584?

[naemono]

Is it a fix for #8584?

Yes it is. I missed adding that to the initial description, but now have added this. Thank you!