Merged
Conversation
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔍 Preview links for changed docs |
barkbay
reviewed
Dec 18, 2025
Use requeuerbac from association package. delete unused func Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Contributor
Author
This has now been added: ❯ kc view-secret -n elastic kibana-sample-kb-config 'telemetry.yml' | yq '.eck.stats.autoopsagentpolicies'
helm_resource_count: 0
pod_count: 1
resource_count: 1 |
pebrc
reviewed
Dec 19, 2025
pebrc
reviewed
Dec 19, 2025
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Contributor
Author
|
buildkite test this -f p=kind,t=TestAutoOpsAgentPolicy -m s=9.2.0 |
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
pebrc
reviewed
Dec 22, 2025
pebrc
approved these changes
Dec 22, 2025
Collaborator
There was a problem hiding this comment.
Looks good. Let's undo that rename of policyFromLabels though.
I will create a few follow up issues:
- status reporting is very bare-bones, we should maybe offer a bit more traceablity
- phase calculation could be cleaner (but I don't see it as a blocker for merging) there is a lot of overlap in responsiblity between reconcile.go and a derivation of the status phase from the error/ready count
- we should add support for an explicit namespace selector to allow uses to restrict the reach of the policy (we have the RBAC access reviews but that is more a cluster admin level feature, the namespace selector would be a user level feature)
This was referenced Dec 22, 2025
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Contributor
Author
|
buildkite test this -f p=kind -m s=9.2.0,s=8.19.6 |
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
…o ccm-integration Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8789
What is this change?
This adds a new CRD
AutoOpsAgentPolicythat allows Elastic AutoOps to be integrated into self-managed ECK clusters.TODO
Allow parts of the configuration (configmap) to be overriddenlocalhost. -This is still non-functional, but a wipThis is now fully functional.Implementation Notes
Currently if the policy is in the same namespace as ECK operator the query for ES clusters is cluster-scoped, and if it's outside of the operator namespace, it's namespace scoped. This follows what we did for SSP, but recent discussions are questioning this behavior. (This behavior could quickly change and default to cluster-scoped always, which seems to make sense)Needs testing