Fix broken link to Elasticsearch "heap size" docs#3894
Conversation
kellyemurphy
left a comment
There was a problem hiding this comment.
LGTM
Looks like there is a tool to generate backports that this repo uses.
|
Thanks @kellyemurphy! Looks like I'm not authorized to merge in this repo. :-( |
| If `ES_JAVA_OPTS` is not defined, the Elasticsearch default heap size of 1Gi will be in effect. | ||
|
|
||
| See also: link:https://www.elastic.co/guide/en/elasticsearch/reference/current/heap-size.html[Elasticsearch documentation on setting the heap size] | ||
| For more information, see the entry for `heap size` in the link:{ref}/important-settings.html[Important Elasticsearch configuration] documentation. No newline at end of file |
There was a problem hiding this comment.
I guess {ref} here actually points to the Elasticsearch reference url base path?
What we usually do is set a label for the smallest version (here that would be 0.9 - in practice I'm not sure we care much about updating docs for versions older than 1.0?) in the PR that targets master (this PR). Then we create a bunch of PRs with the |
|
@kilfoyle please let me know if you need help with the backport PRs! |
|
Thanks for your help @sebgl Some background on this: The CI checks for the docs builds are very sensitive, and will fail if any broken links are detected even in outdated releases. So a broken link even in the I've opened backports for: I see @charith-elastic (Thanks Charith!) has suggested we can override the failed CI checks on some of these. Since I don't have authority to merge in this repo, could I ask either of you to help me with that? |
Hi @sebgl, May I ask you to review this PR for me, or point me in the right direction? This fixes a link in the K8s docs that will break once we merge other changes for the stack 7.10 release, so this will allow the docs build to pass ( elastic/docs#1994 ).
Also, I'll need to backport this to releases
0.9,1.0-beta,1.0,1.1, and1.2. Can you let me know if I've got the right labels for that? If so, I assume I just create the backports manually, right?Sorry for the all the questions. Arianna is out this week and I'm a new visitor to this repo. :-)