Ignore timestamp in redis, haproxy and system filebeat module#9855
Merged
kaiyan-sheng merged 3 commits intoelastic:masterfrom Jan 2, 2019
kaiyan-sheng:ignore_timestamp
Merged
Ignore timestamp in redis, haproxy and system filebeat module#9855kaiyan-sheng merged 3 commits intoelastic:masterfrom kaiyan-sheng:ignore_timestamp
kaiyan-sheng merged 3 commits intoelastic:masterfrom
kaiyan-sheng:ignore_timestamp
Conversation
andrewkroh
approved these changes
Jan 2, 2019
Member
andrewkroh
left a comment
andrewkroh
left a comment
There was a problem hiding this comment.
This is a better solution so if this passes on CI let's go with it.
Fixing formatting
kaiyan-sheng
added
Filebeat
kaiyan-sheng
added a commit
that referenced
this pull request
Jan 3, 2019
…ebeat module (#9855) (#9858) * Ignore timestamp in redis, haproxy and system filebeat module (#9855) * Ignore timestamp in redis, haproxy and system filebeat module * Fixing formatting (cherry picked from commit b9a20f7) * Use event.dataset in if statement * Update golden files for icinga/startup test to exclude timestamp (#9506) The icing/startup log file does not contain a timestamp. Because of this the timestamp from filebeat is taken. During the generation of golden files still a timestamp was added but every skipped on comparison. Instead now the timestamp is not added to the generated file anymore to now show a diff each time GENERATE is run. * Regenerate expectations for logs without timestamps (#9862) * Rerun GENERATE=1 to update expected json files
kaiyan-sheng
added a commit
that referenced
this pull request
Jan 3, 2019
…ebeat module (#9855) (#9857) * Ignore timestamp in redis, haproxy and system filebeat module (#9855) * Ignore timestamp in redis, haproxy and system filebeat module * Fixing formatting (cherry picked from commit b9a20f7) * Change to use event.dataset instead * Update golden files for icinga/startup test to exclude timestamp (#9506) The icing/startup log file does not contain a timestamp. Because of this the timestamp from filebeat is taken. During the generation of golden files still a timestamp was added but every skipped on comparison. Instead now the timestamp is not added to the generated file anymore to now show a diff each time GENERATE is run. * Regenerate expectations for logs without timestamps (#9862) * Rerun icinga redis haproxy and system modules with GENERATE=1
Contributor
|
Thanks for the quick fix on this. There is a difference from incinga to redis / haproxy in that incinga does not have a timestamp at all and these have a timestamp but no year. To still test that we convert the timestamps correctly it would be nice if the |
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Jan 15, 2019
…ebeat module (elastic#9855) (elastic#9858) * Ignore timestamp in redis, haproxy and system filebeat module (elastic#9855) * Ignore timestamp in redis, haproxy and system filebeat module * Fixing formatting (cherry picked from commit b9a20f7) * Use event.dataset in if statement * Update golden files for icinga/startup test to exclude timestamp (elastic#9506) The icing/startup log file does not contain a timestamp. Because of this the timestamp from filebeat is taken. During the generation of golden files still a timestamp was added but every skipped on comparison. Instead now the timestamp is not added to the generated file anymore to now show a diff each time GENERATE is run. * Regenerate expectations for logs without timestamps (elastic#9862) * Rerun GENERATE=1 to update expected json files (cherry picked from commit 6defdd4)
jsoriano
added
v6.5.5
and removed
needs_backport
jsoriano
added a commit
that referenced
this pull request
Jan 17, 2019
…ebeat module (#9855) (#9858) (#10072) (cherry picked from commit b9a20f7) The icing/startup log file does not contain a timestamp. Because of this the timestamp from filebeat is taken. During the generation of golden files still a timestamp was added but every skipped on comparison. Instead now the timestamp is not added to the generated file anymore to now show a diff each time GENERATE is run. (cherry picked from commit 6defdd4) Co-authored-by: Nicolas Ruflin <spam@ruflin.com> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ebeat module (elastic#9855) (elastic#9858) * Ignore timestamp in redis, haproxy and system filebeat module (elastic#9855) * Ignore timestamp in redis, haproxy and system filebeat module * Fixing formatting (cherry picked from commit a5f0323) * Use event.dataset in if statement * Update golden files for icinga/startup test to exclude timestamp (elastic#9506) The icing/startup log file does not contain a timestamp. Because of this the timestamp from filebeat is taken. During the generation of golden files still a timestamp was added but every skipped on comparison. Instead now the timestamp is not added to the generated file anymore to now show a diff each time GENERATE is run. * Regenerate expectations for logs without timestamps (elastic#9862) * Rerun GENERATE=1 to update expected json files
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ebeat module (elastic#9855) (elastic#9858) (elastic#10072) (cherry picked from commit a5f0323) The icing/startup log file does not contain a timestamp. Because of this the timestamp from filebeat is taken. During the generation of golden files still a timestamp was added but every skipped on comparison. Instead now the timestamp is not added to the generated file anymore to now show a diff each time GENERATE is run. (cherry picked from commit 6defdd4) Co-authored-by: Nicolas Ruflin <spam@ruflin.com> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another way to solve this issue #9849 is to ignore timestamp in test_modules.py for redis, haproxy and system filebeat module.