Add grok pattern to support different timestamp fmt in redis log#10033
Merged
kaiyan-sheng merged 29 commits intoelastic:masterfrom Jan 14, 2019
kaiyan-sheng:redis_timestamp
Merged
Add grok pattern to support different timestamp fmt in redis log#10033kaiyan-sheng merged 29 commits intoelastic:masterfrom kaiyan-sheng:redis_timestamp
kaiyan-sheng merged 29 commits intoelastic:masterfrom
kaiyan-sheng:redis_timestamp
Conversation
Remove default version qualifier and rename the environment variable to set it from `BEAT_VERSION_QUALIFIER` to `VERSION_QUALIFIER` this will align with other parts of the stack. **Tested with filebeat.** ``` ❯ ./filebeat version [08:39:01] filebeat version 7.0.0 (amd64), libbeat 7.0.0 [0a0c267 built 2018-11-19 13:38:15 +0000 UTC] ``` **Without the patch** ``` ❯ ./filebeat version [08:40:07] filebeat version 7.0.0-alpha1 (amd64), libbeat 7.0.0-alpha1 [b007837 built 2018-11-19 13:39:59 +0000 UTC] ``` Fixes: #8384
kaiyan-sheng
added
review
Filebeat
Contributor
Author
|
Turned out redis logs have timestamp including year. But because of the change in #9855, timestamp is removed from generated json file under module/redis/log/test. |
ruflin
approved these changes
Jan 14, 2019
kaiyan-sheng
added a commit
that referenced
this pull request
Jan 16, 2019
…tamp fmt in redis log (#10056) * Add grok pattern to support different timestamp fmt in redis log (#10033) * Add grok pattern to support different timestamp fmt in redis log * Add changelog * Fix rebase issue (cherry picked from commit 2ec7b55) * Rerun GENEREATE=1 with 6.x test environment * Deleted log level by mistake
kaiyan-sheng
removed
the
needs_backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For redis 5.0.3, timestamp has year in date instead of just month and day. To fix this, a new grok pattern needs to be added to make sure the
yearpart is captured.closes #9819