[filebeat] update changelog: add fix panic when registering metrics#45967
[filebeat] update changelog: add fix panic when registering metrics#45967AndersonQ merged 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Sorry for the delay, this should be unblocked now that the go vet errors are resolved. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
aa982c2 to
6df7ddb
Compare
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Does this need to be backported? What version was the problem introduced in? |
We started to see it only on main as there are more metrics being added, it became easier to trigger the bug. However the bug on the monitoring lib has existed for quite some time. #45944 has been backported to 9.0 and 9.1, the 8.19 PR is still open. So we can backport it as well. Also there aren't much changes on agent-libs, just this bug fix, go vet changes and 2 additions: elastic/elastic-agent-libs@v0.21.5...v0.22.2 seems ok to backport and brings value. I'll add the tags |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319) could cause filestream to panic when registering its metrics (elastic#45822). elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed. This commit updates the chancgelog
6df7ddb to
381cd05
Compare
…trics (#45967) * update elastic-agent-libs to fix panic when registering metrics A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319) could cause filestream to panic when registering its metrics (#45822). elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed. This commit updates the chancgelog * fix changelog and PR number (cherry picked from commit 1e1dbba)
…trics (#45967) * update elastic-agent-libs to fix panic when registering metrics A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319) could cause filestream to panic when registering its metrics (#45822). elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed. This commit updates the chancgelog * fix changelog and PR number (cherry picked from commit 1e1dbba)
…trics (#45967) * update elastic-agent-libs to fix panic when registering metrics A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319) could cause filestream to panic when registering its metrics (#45822). elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed. This commit updates the chancgelog * fix changelog and PR number (cherry picked from commit 1e1dbba)
…trics (#45967) (#46320) * update elastic-agent-libs to fix panic when registering metrics A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319) could cause filestream to panic when registering its metrics (#45822). elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed. This commit updates the chancgelog * fix changelog and PR number (cherry picked from commit 1e1dbba) Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
…n registering metrics (#46321) * [filebeat] update changelog: add fix panic when registering metrics (#45967) A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319) could cause filestream to panic when registering its metrics (#45822). elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed. This commit updates the chancgelog (cherry picked from commit 1e1dbba) --------- Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
…en registering metrics (#46319) * [filebeat] update changelog: add fix panic when registering metrics (#45967) A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319) could cause filestream to panic when registering its metrics (#45822). elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed. This commit updates the changelog (cherry picked from commit 1e1dbba) * remove unrelated changelog --------- Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Proposed commit message
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
How to test this PR locally
Follow the steps on #45822 to ensure the panic does not happen
Related issues