Skip to content

[filebeat] update changelog: add fix panic when registering metrics#45967

Merged
AndersonQ merged 2 commits intoelastic:mainfrom
AndersonQ:45822-upgrade-elastic-agent-libs
Aug 29, 2025
Merged

[filebeat] update changelog: add fix panic when registering metrics#45967
AndersonQ merged 2 commits intoelastic:mainfrom
AndersonQ:45822-upgrade-elastic-agent-libs

Conversation

@AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Aug 13, 2025

Proposed commit message

update elastic-agent-libs to fix panic when registering metrics

A race condition on elastic-agent-libs (https://github.com/elastic/elastic-agent-libs/issues/319)
could cause filestream to panic when registering its metrics (https://github.com/elastic/beats/issues/45822).
elastic-agent-libs was updated to v0.23.0 by commit https://github.com/elastic/beats/commit/a601b44f74cfdae6f0d63e05dc3b2f4c478206b0, which has the issue fixed.
This commit updates the chancgelog

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

  • N/A

How to test this PR locally

Follow the steps on #45822 to ensure the panic does not happen

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 13, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Aug 13, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @AndersonQ? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@AndersonQ AndersonQ added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 15, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 15, 2025
@mauri870
Copy link
Member

Sorry for the delay, this should be unblocked now that the go vet errors are resolved.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 45822-upgrade-elastic-agent-libs upstream/45822-upgrade-elastic-agent-libs
git merge upstream/main
git push upstream 45822-upgrade-elastic-agent-libs

@AndersonQ AndersonQ force-pushed the 45822-upgrade-elastic-agent-libs branch 3 times, most recently from aa982c2 to 6df7ddb Compare August 26, 2025 09:44
@AndersonQ AndersonQ marked this pull request as ready for review August 26, 2025 09:53
@AndersonQ AndersonQ requested review from a team as code owners August 26, 2025 09:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@AndersonQ AndersonQ added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Aug 27, 2025
@cmacknz
Copy link
Member

cmacknz commented Aug 27, 2025

Does this need to be backported? What version was the problem introduced in?

@AndersonQ
Copy link
Member Author

Does this need to be backported? What version was the problem introduced in?

We started to see it only on main as there are more metrics being added, it became easier to trigger the bug. However the bug on the monitoring lib has existed for quite some time.

#45944 has been backported to 9.0 and 9.1, the 8.19 PR is still open. So we can backport it as well. Also there aren't much changes on agent-libs, just this bug fix, go vet changes and 2 additions: elastic/elastic-agent-libs@v0.21.5...v0.22.2

seems ok to backport and brings value. I'll add the tags

@AndersonQ AndersonQ added backport-9.0 Automated backport to the 9.0 branch backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch labels Aug 27, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 45822-upgrade-elastic-agent-libs upstream/45822-upgrade-elastic-agent-libs
git merge upstream/main
git push upstream 45822-upgrade-elastic-agent-libs

A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319)
could cause filestream to panic when registering its metrics (elastic#45822).
elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed.
This commit updates the chancgelog
@AndersonQ AndersonQ force-pushed the 45822-upgrade-elastic-agent-libs branch from 6df7ddb to 381cd05 Compare August 29, 2025 09:27
@AndersonQ AndersonQ removed request for a team August 29, 2025 09:30
@AndersonQ AndersonQ removed the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Aug 29, 2025
@AndersonQ AndersonQ requested a review from belimawr August 29, 2025 09:40
@AndersonQ AndersonQ requested a review from mauri870 August 29, 2025 14:49
@AndersonQ
Copy link
Member Author

@belimawr, @mauri870 done. Also I put it in the right section. I linked the PR that actually upgrades the lib

@AndersonQ AndersonQ enabled auto-merge (squash) August 29, 2025 14:54
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@AndersonQ AndersonQ merged commit 1e1dbba into elastic:main Aug 29, 2025
12 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Aug 29, 2025
…trics (#45967)

* update elastic-agent-libs to fix panic when registering metrics

A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319)
could cause filestream to panic when registering its metrics (#45822).
elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed.
This commit updates the chancgelog

* fix changelog and PR number

(cherry picked from commit 1e1dbba)
mergify bot pushed a commit that referenced this pull request Aug 29, 2025
…trics (#45967)

* update elastic-agent-libs to fix panic when registering metrics

A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319)
could cause filestream to panic when registering its metrics (#45822).
elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed.
This commit updates the chancgelog

* fix changelog and PR number

(cherry picked from commit 1e1dbba)
mergify bot pushed a commit that referenced this pull request Aug 29, 2025
…trics (#45967)

* update elastic-agent-libs to fix panic when registering metrics

A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319)
could cause filestream to panic when registering its metrics (#45822).
elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed.
This commit updates the chancgelog

* fix changelog and PR number

(cherry picked from commit 1e1dbba)
@AndersonQ AndersonQ changed the title [filebeat] update elastic-agent-libs to fix panic when registering metrics [filebeat] update changelog: add fix panic when registering metrics Sep 1, 2025
AndersonQ added a commit that referenced this pull request Sep 1, 2025
…trics (#45967) (#46320)

* update elastic-agent-libs to fix panic when registering metrics

A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319)
could cause filestream to panic when registering its metrics (#45822).
elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed.
This commit updates the chancgelog

* fix changelog and PR number

(cherry picked from commit 1e1dbba)

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
AndersonQ added a commit that referenced this pull request Sep 2, 2025
…n registering metrics (#46321)

* [filebeat] update changelog: add fix panic when registering metrics (#45967)

A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319)
could cause filestream to panic when registering its metrics (#45822).
elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed.
This commit updates the chancgelog

(cherry picked from commit 1e1dbba)
---------

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
AndersonQ added a commit that referenced this pull request Sep 2, 2025
…en registering metrics (#46319)

* [filebeat] update changelog: add fix panic when registering metrics (#45967)

A race condition on elastic-agent-libs (elastic/elastic-agent-libs#319)
could cause filestream to panic when registering its metrics (#45822).
elastic-agent-libs was updated to v0.23.0 by commit a601b44, which has the issue fixed.
This commit updates the changelog

(cherry picked from commit 1e1dbba)

* remove unrelated changelog

---------

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch backport-9.1 Automated backport to the 9.1 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filebeat panic: name gzip_started already used

5 participants