Skip to content

fix: asdf issues with updatecli in the tool-versions#45286

Merged
v1v merged 2 commits intoelastic:mainfrom
v1v:feature/updatec-li-version
Jul 10, 2025
Merged

fix: asdf issues with updatecli in the tool-versions#45286
v1v merged 2 commits intoelastic:mainfrom
v1v:feature/updatec-li-version

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Jul 10, 2025

Proposed commit message

Some issues when using asdf and no plugins available for the updatecli, let's use a different file for now.

See #45199 (comment)

More context, #43743 introduced the .tool-versions file, but it only contained an entry for the updatecli, as asdf is used, let's avoid surprises with some asdf plugins and other things.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@v1v v1v self-assigned this Jul 10, 2025
@v1v v1v added the backport-active-all Automated backport with mergify to all the active branches label Jul 10, 2025
@v1v v1v requested review from a team as code owners July 10, 2025 10:29
@v1v v1v requested review from faec and mauri870 July 10, 2025 10:29
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2025
@botelastic
Copy link
Copy Markdown

botelastic Bot commented Jul 10, 2025

This pull request doesn't have a Team:<team> label.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Copy Markdown

@pazone pazone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it makes sense to create oblt-cli plugin for asdf

@v1v v1v disabled auto-merge July 10, 2025 12:50
@v1v v1v merged commit 68600b7 into elastic:main Jul 10, 2025
15 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

@Mergifyio backport 8.17 8.18 8.19 9.0 9.1

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 10, 2025

backport 8.17 8.18 8.19 9.0 9.1

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit 68600b7)

# Conflicts:
#	.github/workflows/bump-elastic-stack-snapshot.yml
#	.github/workflows/bump-golang.yml
#	.github/workflows/updatecli-compose.yml
#	.updatecli-version
mergify Bot pushed a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit 68600b7)

# Conflicts:
#	.github/workflows/bump-elastic-stack-snapshot.yml
#	.github/workflows/bump-golang.yml
#	.github/workflows/updatecli-compose.yml
#	.updatecli-version
mergify Bot pushed a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit 68600b7)

# Conflicts:
#	.github/workflows/bump-elastic-stack-snapshot.yml
#	.github/workflows/bump-golang.yml
#	.github/workflows/updatecli-compose.yml
#	.updatecli-version
@v1v
Copy link
Copy Markdown
Member Author

v1v commented Jul 10, 2025

I merged after getting the approvals and bypass the codeowners, to unblock some work for #45199. Those files are new and used by the updatecli automation we built, so I analysed they were not used anywhere else

@v1v v1v added backport-skip Skip notification from the automated backport with mergify and removed backport-active-all Automated backport with mergify to all the active branches labels Jul 10, 2025
mergify Bot pushed a commit that referenced this pull request Jul 10, 2025
(cherry picked from commit 68600b7)

# Conflicts:
#	.github/workflows/bump-elastic-stack-snapshot.yml
#	.github/workflows/bump-golang.yml
#	.github/workflows/updatecli-compose.yml
#	.updatecli-version
mergify Bot pushed a commit that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants