Skip to content

[FIPS][libbeat] Use VM with FIPS provider to run libbeat fips tests#45199

Merged
michel-laterman merged 17 commits into
elastic:mainfrom
michel-laterman:use-fips-provider
Jul 17, 2025
Merged

[FIPS][libbeat] Use VM with FIPS provider to run libbeat fips tests#45199
michel-laterman merged 17 commits into
elastic:mainfrom
michel-laterman:use-fips-provider

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

Proposed commit message

Use VM with FIPS provider to run libbeat fips tests.

This is meant to unblock #45158

Disruptive User Impact

N/A

@michel-laterman michel-laterman requested review from a team as code owners July 4, 2025 15:30
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@michel-laterman michel-laterman added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jul 4, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 4, 2025
@michel-laterman michel-laterman added needs_team Indicates that the issue/PR needs a Team:* label backport-8.19 Automated backport to the 8.19 branch labels Jul 4, 2025
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 4, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 4, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @michel-laterman? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Comment thread .buildkite/libbeat/pipeline.libbeat.yml Outdated
Comment thread .buildkite/libbeat/pipeline.libbeat.yml Outdated
Comment thread .buildkite/libbeat/pipeline.libbeat.yml Outdated
Comment thread .buildkite/libbeat/pipeline.libbeat.yml Outdated
Comment thread .buildkite/libbeat/pipeline.libbeat.yml Outdated
@michel-laterman
Copy link
Copy Markdown
Contributor Author

Looks like there is an issue on the new VM when running python3

>> python test: Unit Testing
--
  | No version is set for command python3
  | Consider adding one of the following versions in your config file at
  | python 3.10.9
  | python 3.9.13

Comment thread .buildkite/libbeat/pipeline.libbeat.yml Outdated
@michel-laterman
Copy link
Copy Markdown
Contributor Author

python keystore tests are failing; i think this is expected as we don't currently support keystore for FIPS binaries; i'll make a change to the pipelines to only run the go unit tests on the VM that has a FIPS provider

@michel-laterman
Copy link
Copy Markdown
Contributor Author

buildkite test this

@michel-laterman michel-laterman requested a review from v1v July 14, 2025 15:19
@michel-laterman
Copy link
Copy Markdown
Contributor Author

@v1v, can you please re-review?

Comment thread .buildkite/libbeat/pipeline.libbeat.yml Outdated
Comment thread .buildkite/libbeat/pipeline.libbeat.yml Outdated
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@michel-laterman michel-laterman requested a review from v1v July 16, 2025 23:25
@michel-laterman michel-laterman merged commit ba3fc29 into elastic:main Jul 17, 2025
21 checks passed
mergify Bot pushed a commit that referenced this pull request Jul 17, 2025
…45199)

* Use VM with FIPS provider to run libbeat fips tests

* Add GOEXPERIMENT=systemcrypto

* use FIPS VM image for Beats

* Update .buildkite/libbeat/pipeline.libbeat.yml

* Apply suggestions from code review

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

* Only run requirefips unit tests on VM with provider

* Remove env var

* Add ASDF_PYTHON_VERSION

* Change python version, use VM family

* Revert change to VM image name

* libbeat provisioner VM only runs Go unit tests

* Switch to imagePrefix

* Apply suggestions from code review

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
(cherry picked from commit ba3fc29)
@michel-laterman michel-laterman added the backport-9.1 Automated backport to the 9.1 branch label Jul 17, 2025
mergify Bot pushed a commit that referenced this pull request Jul 17, 2025
…45199)

* Use VM with FIPS provider to run libbeat fips tests

* Add GOEXPERIMENT=systemcrypto

* use FIPS VM image for Beats

* Update .buildkite/libbeat/pipeline.libbeat.yml

* Apply suggestions from code review

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

* Only run requirefips unit tests on VM with provider

* Remove env var

* Add ASDF_PYTHON_VERSION

* Change python version, use VM family

* Revert change to VM image name

* libbeat provisioner VM only runs Go unit tests

* Switch to imagePrefix

* Apply suggestions from code review

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
(cherry picked from commit ba3fc29)
michel-laterman added a commit that referenced this pull request Jul 17, 2025
…45199) (#45429)

* Use VM with FIPS provider to run libbeat fips tests

* Add GOEXPERIMENT=systemcrypto

* use FIPS VM image for Beats

* Update .buildkite/libbeat/pipeline.libbeat.yml

* Apply suggestions from code review



* Only run requirefips unit tests on VM with provider

* Remove env var

* Add ASDF_PYTHON_VERSION

* Change python version, use VM family

* Revert change to VM image name

* libbeat provisioner VM only runs Go unit tests

* Switch to imagePrefix

* Apply suggestions from code review



---------


(cherry picked from commit ba3fc29)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
michel-laterman added a commit that referenced this pull request Jul 17, 2025
…45199) (#45434)

* Use VM with FIPS provider to run libbeat fips tests

* Add GOEXPERIMENT=systemcrypto

* use FIPS VM image for Beats

* Update .buildkite/libbeat/pipeline.libbeat.yml

* Apply suggestions from code review



* Only run requirefips unit tests on VM with provider

* Remove env var

* Add ASDF_PYTHON_VERSION

* Change python version, use VM family

* Revert change to VM image name

* libbeat provisioner VM only runs Go unit tests

* Switch to imagePrefix

* Apply suggestions from code review



---------


(cherry picked from commit ba3fc29)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants