[FIPS][libbeat] Use VM with FIPS provider to run libbeat fips tests#45199
Merged
michel-laterman merged 17 commits intoJul 17, 2025
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
michel-laterman
commented
Jul 4, 2025
Merged
6 tasks
v1v
reviewed
Jul 10, 2025
6 tasks
v1v
reviewed
Jul 10, 2025
This was referenced Jul 10, 2025
v1v
reviewed
Jul 10, 2025
Contributor
Author
|
Looks like there is an issue on the new VM when running python3 |
v1v
reviewed
Jul 10, 2025
Contributor
Author
|
python keystore tests are failing; i think this is expected as we don't currently support keystore for FIPS binaries; i'll make a change to the pipelines to only run the go unit tests on the VM that has a FIPS provider |
Contributor
Author
|
buildkite test this |
Contributor
Author
|
@v1v, can you please re-review? |
v1v
reviewed
Jul 16, 2025
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v
approved these changes
Jul 17, 2025
mergify Bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
…45199) * Use VM with FIPS provider to run libbeat fips tests * Add GOEXPERIMENT=systemcrypto * use FIPS VM image for Beats * Update .buildkite/libbeat/pipeline.libbeat.yml * Apply suggestions from code review Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * Only run requirefips unit tests on VM with provider * Remove env var * Add ASDF_PYTHON_VERSION * Change python version, use VM family * Revert change to VM image name * libbeat provisioner VM only runs Go unit tests * Switch to imagePrefix * Apply suggestions from code review Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> --------- Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> (cherry picked from commit ba3fc29)
mergify Bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
…45199) * Use VM with FIPS provider to run libbeat fips tests * Add GOEXPERIMENT=systemcrypto * use FIPS VM image for Beats * Update .buildkite/libbeat/pipeline.libbeat.yml * Apply suggestions from code review Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * Only run requirefips unit tests on VM with provider * Remove env var * Add ASDF_PYTHON_VERSION * Change python version, use VM family * Revert change to VM image name * libbeat provisioner VM only runs Go unit tests * Switch to imagePrefix * Apply suggestions from code review Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> --------- Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> (cherry picked from commit ba3fc29)
michel-laterman
added a commit
that referenced
this pull request
Jul 17, 2025
…45199) (#45429) * Use VM with FIPS provider to run libbeat fips tests * Add GOEXPERIMENT=systemcrypto * use FIPS VM image for Beats * Update .buildkite/libbeat/pipeline.libbeat.yml * Apply suggestions from code review * Only run requirefips unit tests on VM with provider * Remove env var * Add ASDF_PYTHON_VERSION * Change python version, use VM family * Revert change to VM image name * libbeat provisioner VM only runs Go unit tests * Switch to imagePrefix * Apply suggestions from code review --------- (cherry picked from commit ba3fc29) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
michel-laterman
added a commit
that referenced
this pull request
Jul 17, 2025
…45199) (#45434) * Use VM with FIPS provider to run libbeat fips tests * Add GOEXPERIMENT=systemcrypto * use FIPS VM image for Beats * Update .buildkite/libbeat/pipeline.libbeat.yml * Apply suggestions from code review * Only run requirefips unit tests on VM with provider * Remove env var * Add ASDF_PYTHON_VERSION * Change python version, use VM family * Revert change to VM image name * libbeat provisioner VM only runs Go unit tests * Switch to imagePrefix * Apply suggestions from code review --------- (cherry picked from commit ba3fc29) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Use VM with FIPS provider to run libbeat fips tests.
This is meant to unblock #45158
Disruptive User Impact
N/A