Skip to content

[9.0](backport #45234) otelmap: handle conversion of struct types#45239

Merged
mauri870 merged 1 commit into9.0from
mergify/bp/9.0/pr-45234
Jul 8, 2025
Merged

[9.0](backport #45234) otelmap: handle conversion of struct types#45239
mauri870 merged 1 commit into9.0from
mergify/bp/9.0/pr-45234

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jul 8, 2025

Proposed commit message

The otelmap package does not handle struct types properly, the convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by serializing to json and back, resulting in a map of keys and values.

We have plans to try and extend otelmap to use the libbeat generic serializer, but that is part of a large refactor that should be done in a separate PR.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues


This is an automatic backport of pull request #45234 done by [Mergify](https://mergify.com).

The otelmap package does not handle struct types properly, the
convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by
serializing to json and back, resulting in a map of keys and values.

(cherry picked from commit 2685f9c)
@mergify mergify Bot requested a review from a team as a code owner July 8, 2025 15:24
@mergify mergify Bot added the backport label Jul 8, 2025
@mergify mergify Bot requested review from AndersonQ and faec and removed request for a team July 8, 2025 15:24
@mergify mergify Bot added the backport label Jul 8, 2025
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 8, 2025
@github-actions github-actions Bot added cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jul 8, 2025
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 8, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 enabled auto-merge (squash) July 8, 2025 15:29
@mauri870 mauri870 merged commit 5ad40b4 into 9.0 Jul 8, 2025
177 of 178 checks passed
@mauri870 mauri870 deleted the mergify/bp/9.0/pr-45234 branch July 8, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants