Skip to content

otelmap: handle conversion of struct types#45234

Merged
mauri870 merged 1 commit intoelastic:mainfrom
mauri870:otelmap-struct
Jul 8, 2025
Merged

otelmap: handle conversion of struct types#45234
mauri870 merged 1 commit intoelastic:mainfrom
mauri870:otelmap-struct

Conversation

@mauri870
Copy link
Copy Markdown
Member

@mauri870 mauri870 commented Jul 8, 2025 •
edited
Loading

Proposed commit message

The otelmap package does not handle struct types properly, the convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by serializing to json and back, resulting in a map of keys and values.

We have plans to try and extend otelmap to use the libbeat generic serializer, but that is part of a large refactor that should be done in a separate PR.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@mauri870 mauri870 requested a review from a team as a code owner July 8, 2025 12:03
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 8, 2025
@mauri870 mauri870 self-assigned this Jul 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mauri870 mauri870 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 8, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 8, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 8, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 8, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mauri870? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mauri870 mauri870 added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-8.19 Automated backport to the 8.19 branch cleanup labels Jul 8, 2025
@mauri870
otelmap: handle conversion of struct types
efb6fde 
The otelmap package does not handle struct types properly, the
convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by
serializing to json and back, resulting in a map of keys and values.
@mauri870 mauri870 merged commit 2685f9c into elastic:main Jul 8, 2025
204 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

@Mergifyio backport 9.0 9.1

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 8, 2025 •
edited
Loading

backport 9.0 9.1

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jul 8, 2025
@mauri870 @mergify
otelmap: handle conversion of struct types (#45234)
64e6e8b 
The otelmap package does not handle struct types properly, the
convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by
serializing to json and back, resulting in a map of keys and values.

(cherry picked from commit 2685f9c)
mergify Bot pushed a commit that referenced this pull request Jul 8, 2025
@mauri870 @mergify
otelmap: handle conversion of struct types (#45234)
8c56edc 
The otelmap package does not handle struct types properly, the
convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by
serializing to json and back, resulting in a map of keys and values.

(cherry picked from commit 2685f9c)
This was referenced Jul 8, 2025
Merged
Merged
mergify Bot pushed a commit that referenced this pull request Jul 8, 2025
@mauri870 @mergify
otelmap: handle conversion of struct types (#45234)
7736ef3 
The otelmap package does not handle struct types properly, the
convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by
serializing to json and back, resulting in a map of keys and values.

(cherry picked from commit 2685f9c)
@mergify mergify Bot mentioned this pull request Jul 8, 2025
Merged
6 tasks
mauri870 added a commit that referenced this pull request Jul 8, 2025
@mergify @mauri870
otelmap: handle conversion of struct types (#45234) (#45240)
860ace2 
The otelmap package does not handle struct types properly, the
convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by
serializing to json and back, resulting in a map of keys and values.

(cherry picked from commit 2685f9c)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Jul 8, 2025
@mergify @mauri870
otelmap: handle conversion of struct types (#45234) (#45239)
5ad40b4 
The otelmap package does not handle struct types properly, the
convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by
serializing to json and back, resulting in a map of keys and values.

(cherry picked from commit 2685f9c)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Jul 8, 2025
@mergify @mauri870
otelmap: handle conversion of struct types (#45234) (#45241)
5333689 
The otelmap package does not handle struct types properly, the
convertion of a struct results in a string error.

To follow the libbeat behavior, handle struct types the same way, by
serializing to json and back, resulting in a map of keys and values.

(cherry picked from commit 2685f9c)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
@khushijain21
Copy link
Copy Markdown
Contributor

khushijain21 commented Jul 9, 2025

We have plans to try and extend otelmap to use the libbeat generic serializer, but that is part of a large refactor that should be done in a separate PR.

Should we have an issue tracking this?

@mauri870
Copy link
Copy Markdown
Member Author

mauri870 commented Jul 10, 2025

Should we have an issue tracking this?

More likely, yes. I want to confirm if it is feasible first. When I did a first take on this I found lots of little discrepancies between the current otelmap and the libbeat generic serializer. If we are bound to change libbeat serializer to get the same behavior then it's not worth it, as we risk breaking standalone beats.

@khushijain21 khushijain21 mentioned this pull request Jul 15, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonQ AndersonQ AndersonQ approved these changes

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@mauri870 mauri870

Labels

backport-8.19 Automated backport to the 8.19 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OTel] Data Serialization fails on struct types

4 participants

@mauri870 @elasticmachine @khushijain21 @AndersonQ