Skip to content

[AutoOps] Remove / revert pre-serialization for OTel#45104

Merged
pickypg merged 1 commit intomainfrom
autoops/revert-serialization
Jun 30, 2025
Merged

[AutoOps] Remove / revert pre-serialization for OTel#45104
pickypg merged 1 commit intomainfrom
autoops/revert-serialization

Conversation

@pickypg
Copy link
Copy Markdown
Member

@pickypg pickypg commented Jun 28, 2025

This reverts commit 38f6842 (#45015).

This is no longer necessary thanks to #45076, #45042, and #45008.

Removing it has no downside and actually improves performance and memory usage a tiny bit by not wastefully marshalling and unmarshalling the event.

@pickypg pickypg self-assigned this Jun 28, 2025
@pickypg pickypg requested a review from a team as a code owner June 28, 2025 00:54
@pickypg pickypg added release-note:skip The PR should be ignored when processing the changelog Team:Opex backport-9.1 Automated backport to the 9.1 branch labels Jun 28, 2025
@botelastic botelastic Bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 28, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 28, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@pickypg pickypg enabled auto-merge (squash) June 28, 2025 00:54
romulo-batista-elastic
romulo-batista-elastic approved these changes Jun 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@romulo-batista-elastic romulo-batista-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pickypg pickypg merged commit 84c0c70 into main Jun 30, 2025
35 checks passed
@pickypg pickypg deleted the autoops/revert-serialization branch June 30, 2025 14:21
mergify Bot pushed a commit that referenced this pull request Jun 30, 2025
@pickypg @mergify
Revert "[AutoOps] Serialize custom struct before sending as event (#4…
3250f61 
…5015)" (#45104)

This reverts commit 38f6842.

(cherry picked from commit 84c0c70)
@mergify mergify Bot mentioned this pull request Jun 30, 2025
Merged
pickypg added a commit that referenced this pull request Jun 30, 2025
@mergify @pickypg
Revert "[AutoOps] Serialize custom struct before sending as event (#4…
32dbd1e 
…5015)" (#45104) (#45120)

This reverts commit 38f6842.

(cherry picked from commit 84c0c70)

Co-authored-by: Chris Earle <pickypg@users.noreply.github.com>
@khushijain21 khushijain21 mentioned this pull request Jul 15, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romulo-batista-elastic romulo-batista-elastic romulo-batista-elastic approved these changes

Assignees

@pickypg pickypg

Labels

backport-9.1 Automated backport to the 9.1 branch release-note:skip The PR should be ignored when processing the changelog Team:Opex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pickypg @romulo-batista-elastic