Skip to content

[OTel] Serialize Maps and nil Better#45042

Merged
pickypg merged 1 commit intomainfrom
otel/handle-maps-more-easily
Jun 26, 2025
Merged

[OTel] Serialize Maps and nil Better#45042
pickypg merged 1 commit intomainfrom
otel/handle-maps-more-easily

Conversation

@pickypg
Copy link
Copy Markdown
Member

@pickypg pickypg commented Jun 25, 2025

This simplifies the serialization of arrays / slices of map[string]any and add tests for inner nil handling.

Proposed commit message

Add better tests for otelmap and simplified arrays and slices and use less reflection.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

No change.

How to test this PR locally

  • Run the tests in otelmap

Related issues

@pickypg
[OTel] Serialize Maps and nil Better
f56eff9 
This simplifies the serialization of arrays / slices of
`map[string]any`.
@pickypg pickypg self-assigned this Jun 25, 2025
@pickypg pickypg requested a review from a team as a code owner June 25, 2025 23:33
@pickypg pickypg added release-note:skip The PR should be ignored when processing the changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-9.0 Automated backport to the 9.0 branch backport-8.19 Automated backport to the 8.19 branch labels Jun 25, 2025
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 25, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 25, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 25, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

khushijain21
khushijain21 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@khushijain21 khushijain21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pickypg pickypg enabled auto-merge (squash) June 26, 2025 01:49
@pickypg pickypg merged commit 63bbc75 into main Jun 26, 2025
205 of 206 checks passed
@pickypg pickypg deleted the otel/handle-maps-more-easily branch June 26, 2025 06:18
mergify Bot pushed a commit that referenced this pull request Jun 26, 2025
@pickypg @mergify
[OTel] Serialize Maps and nil Better (#45042)
4b4d40a 
This simplifies the serialization of arrays / slices of
`map[string]any`.

(cherry picked from commit 63bbc75)
@mergify mergify Bot mentioned this pull request Jun 26, 2025
Merged
6 tasks
mergify Bot pushed a commit that referenced this pull request Jun 26, 2025
@pickypg @mergify
[OTel] Serialize Maps and nil Better (#45042)
f6f0eef 
This simplifies the serialization of arrays / slices of
`map[string]any`.

(cherry picked from commit 63bbc75)
@mergify mergify Bot mentioned this pull request Jun 26, 2025
Merged
6 tasks
pickypg added a commit that referenced this pull request Jun 27, 2025
@mergify @pickypg
[OTel] Serialize Maps and nil Better (#45042) (#45044)
e52ce58 
This simplifies the serialization of arrays / slices of
`map[string]any`.

(cherry picked from commit 63bbc75)

Co-authored-by: Chris Earle <pickypg@users.noreply.github.com>
pickypg added a commit that referenced this pull request Jun 27, 2025
@mergify @pickypg
[OTel] Serialize Maps and nil Better (#45042) (#45043)
6be928f 
This simplifies the serialization of arrays / slices of
`map[string]any`.

(cherry picked from commit 63bbc75)

Co-authored-by: Chris Earle <pickypg@users.noreply.github.com>
@pickypg pickypg mentioned this pull request Jun 28, 2025
Merged
@mergify mergify Bot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khushijain21 khushijain21 khushijain21 approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@pickypg pickypg

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch release-note:skip The PR should be ignored when processing the changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pickypg @elasticmachine @khushijain21