[8.19](backport #45053) [Filebeat] Use existing constant for FIPS distribution#45074
Merged
ycombinator merged 1 commit into8.19from Jul 3, 2025
Merged
[8.19](backport #45053) [Filebeat] Use existing constant for FIPS distribution#45074ycombinator merged 1 commit into8.19from
ycombinator merged 1 commit into8.19from
Conversation
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏 |
mauri870
approved these changes
Jul 2, 2025
e219693 to
35a17f3
Compare
faec
approved these changes
Jul 2, 2025
Contributor
|
@mauri870 @faec Thanks for your LGTMs. AFAICT, the CI failures on this PR are unrelated to the changes in the PR. If you agree, @pierrehilbert could we please force merge this PR so it makes it into |
(cherry picked from commit 6798fe5)
35a17f3 to
97a24e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR is a follow up to #45036. In that PR, a new constant was introduced in libbeat,
common.FIPSModeto determine if we're running a FIPS-capable distribution of a Beat or not. Turns out there was already such a constant in place,version.FIPSDistribution. So this PR here deletescommon.FIPSModeand reusesversion.FIPSDistributioninstead.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
In an environment configured for FIPS, i.e. with the Microsoft Go fork installed and with the OpenSSL FIPS provider installed:
This is an automatic backport of pull request #45053 done by [Mergify](https://mergify.com).