[Filebeat] Use existing constant for FIPS distribution#45053
Merged
ycombinator merged 1 commit intoelastic:mainfrom Jun 26, 2025
Merged
[Filebeat] Use existing constant for FIPS distribution#45053ycombinator merged 1 commit intoelastic:mainfrom
ycombinator merged 1 commit intoelastic:mainfrom
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
belimawr
approved these changes
Jun 26, 2025
mauri870
approved these changes
Jun 26, 2025
Contributor
Author
|
CI is failing like so: This failure is unrelated to the changes in this PR. It can also be seen on
|
Contributor
|
@ycombinator the flaky test PR is merged. |
9af3933 to
c85cdda
Compare
mergify Bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
(cherry picked from commit 6798fe5)
6 tasks
mergify Bot
pushed a commit
that referenced
this pull request
Jun 28, 2025
(cherry picked from commit 6798fe5)
6 tasks
ycombinator
added a commit
that referenced
this pull request
Jun 28, 2025
ycombinator
added a commit
that referenced
this pull request
Jul 2, 2025
(cherry picked from commit 6798fe5)
ycombinator
added a commit
that referenced
this pull request
Jul 2, 2025
(cherry picked from commit 6798fe5)
ycombinator
added a commit
that referenced
this pull request
Jul 3, 2025
(cherry picked from commit 6798fe5)
ycombinator
added a commit
that referenced
this pull request
Jul 3, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR is a follow up to #45036. In that PR, a new constant was introduced in libbeat,
common.FIPSModeto determine if we're running a FIPS-capable distribution of a Beat or not. Turns out there was already such a constant in place,version.FIPSDistribution. So this PR here deletescommon.FIPSModeand reusesversion.FIPSDistributioninstead.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
In an environment configured for FIPS, i.e. with the Microsoft Go fork installed and with the OpenSSL FIPS provider installed: