[8.19](backport #44885) Disable Metricbeat azure module in FIPS builds
#44905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
ycombinator
approved these changes
Jun 18, 2025
shmsr
approved these changes
Jun 18, 2025
Member
shmsr
left a comment
shmsr
left a comment
There was a problem hiding this comment.
Approving; but yes make update is required.
ycombinator
requested review from
AndersonQ and
belimawr
and removed request for
a team
* Add doc about module availability * Exclude non-generated Go code from FIPS build * Adding CHANGELOG entry * Adding doc.go files to workaround excluding all Go files in build * Run make check * Remove CHANGELOG entry (cherry picked from commit 0425c03)
ycombinator
force-pushed
the
mergify/bp/8.19/pr-44885
branch
from
5d1f05f to
9adae6a
Compare
ycombinator
force-pushed
the
mergify/bp/8.19/pr-44885
branch
from
9adae6a to
104d3ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR (similar to #43480) ensures that the Metricbeat
azuremodule code is only compiled in non-FIPS builds of Metricbeat and is, therefore, unavailable in FIPS-capable Metricbeat artifacts.The module depends on the Azure Go SDK. The SDK's code uses the
golang.org/x/crypto/pkcs12package, which is not FIPS-compliant, and the SDK doesn't plan to offer a way to disable the use of this package at compile time (see Azure/azure-sdk-for-go#24336).As such, we have little choice but to exclude the
azuremodule from FIPS-capable Metricbeat builds.The
doc.gofiles added to every metricset in theazuremodule are to prevent compile-time errors like so:Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
FIPS-capable artifacts of Metricbeat will not contain the
azuremodule.This is an automatic backport of pull request #44885 done by [Mergify](https://mergify.com).