-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fips): disable kvm module in fips mode #43480
Conversation
go-libvirt is pulling quite a few x/crypto packages disable kvm modules in fips mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these changes, I wonder whether it really still makes sense to keep the metricbeat/module/kvm
enabled for FIPS mode when metricbeat/module/kvm/status
and metricbeat/module/kvm/dommemstat
are disabled? While the third party libraries in question are removed in this PR, functionality wise I don't see the point in keeping the kvm
module enabled.
Other than that, LGTM
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code, LGTM.
go-libvirt is pulling quite a few x/crypto packages disable kvm modules in fips mode (cherry picked from commit 92aebb3)
go-libvirt is pulling quite a few x/crypto packages disable kvm modules in fips mode (cherry picked from commit 92aebb3)
kvm does not add a metricset, only an asset so there's no impact but I guess we could disable it too |
go-libvirt is pulling quite a few x/crypto packages disable kvm modules in fips mode (cherry picked from commit 92aebb3) Co-authored-by: kruskall <[email protected]>
Proposed commit message
go-libvirt is pulling quite a few x/crypto packages
disable kvm modules in fips mode
should remove the following packages from metricbeat:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs