-
Notifications
You must be signed in to change notification settings - Fork 5k
Disable Metricbeat mssql module in FIPS builds
#44890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request doesn't have a |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
simitt
approved these changes
Jun 18, 2025
shmsr
reviewed
Jun 18, 2025
shmsr
approved these changes
Jun 18, 2025
shmsr
approved these changes
Jun 18, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
* Exclude non-generated Go code from FIPS build * Add doc about module availability * Adding CHANGELOG entry * Adding doc.go files to workaround excluding all Go files in build * Update PR number in CHANGELOG entry * Remove CHANGELOG entry (cherry picked from commit 9f5988f)
6 tasks
ycombinator
added a commit
that referenced
this pull request
Jun 19, 2025
…lds (#44906) * Disable Metricbeat `mssql` module in FIPS builds (#44890) * Exclude non-generated Go code from FIPS build * Add doc about module availability * Adding CHANGELOG entry * Adding doc.go files to workaround excluding all Go files in build * Update PR number in CHANGELOG entry * Remove CHANGELOG entry (cherry picked from commit 9f5988f) * Running mage update --------- Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.19
Automated backport to the 8.19 branch
needs_team
Indicates that the issue/PR needs a Team:* label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR (similar to #43480) ensures that the Metricbeat
mssqlmodule code is only compiled in non-FIPS builds of Metricbeat and is, therefore, unavailable in FIPS-capable Metricbeat artifacts.The module indirectly depends on the Azure Go SDK. The SDK's code uses the
golang.org/x/crypto/pkcs12package, which is not FIPS-compliant, and the SDK doesn't plan to offer a way to disable the use of this package at compile time (see Azure/azure-sdk-for-go#24336).As such, we have little choice but to exclude the
mssqlmodule from FIPS-capable Metricbeat builds.The
doc.gofiles added to every metricset in themssqlmodule are to prevent compile-time errors like so:Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
FIPS-capable artifacts of Metricbeat will not contain the
mssqlmodule.