Skip to content

Conversation

@ycombinator
Copy link
Contributor

Proposed commit message

This PR (similar to #43480) ensures that the Metricbeat mssql module code is only compiled in non-FIPS builds of Metricbeat and is, therefore, unavailable in FIPS-capable Metricbeat artifacts.

The module indirectly depends on the Azure Go SDK. The SDK's code uses the golang.org/x/crypto/pkcs12 package, which is not FIPS-compliant, and the SDK doesn't plan to offer a way to disable the use of this package at compile time (see Azure/azure-sdk-for-go#24336).

As such, we have little choice but to exclude the mssql module from FIPS-capable Metricbeat builds.

The doc.go files added to every metricset in the mssql module are to prevent compile-time errors like so:

build constraints exclude all Go files in x-pack/metricbeat/module/mssql/performance

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

FIPS-capable artifacts of Metricbeat will not contain the mssql module.

@ycombinator ycombinator requested a review from a team as a code owner June 17, 2025 22:58
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2025
@botelastic
Copy link

botelastic bot commented Jun 17, 2025

This pull request doesn't have a Team:<team> label.

@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ycombinator? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ycombinator ycombinator added the backport-8.19 Automated backport to the 8.19 branch label Jun 17, 2025
@ycombinator ycombinator enabled auto-merge (squash) June 18, 2025 18:11
@ycombinator ycombinator merged commit 9f5988f into elastic:main Jun 18, 2025
31 of 34 checks passed
mergify bot pushed a commit that referenced this pull request Jun 18, 2025
* Exclude non-generated Go code from FIPS build

* Add doc about module availability

* Adding CHANGELOG entry

* Adding doc.go files to workaround excluding all Go files in build

* Update PR number in CHANGELOG entry

* Remove CHANGELOG entry

(cherry picked from commit 9f5988f)
@ycombinator ycombinator deleted the fips-disable-mb-mssql branch June 18, 2025 19:31
ycombinator added a commit that referenced this pull request Jun 19, 2025
…lds (#44906)

* Disable Metricbeat `mssql` module in FIPS builds (#44890)

* Exclude non-generated Go code from FIPS build

* Add doc about module availability

* Adding CHANGELOG entry

* Adding doc.go files to workaround excluding all Go files in build

* Update PR number in CHANGELOG entry

* Remove CHANGELOG entry

(cherry picked from commit 9f5988f)

* Running mage update

---------

Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants