-
Notifications
You must be signed in to change notification settings - Fork 5k
[8.19](backport #43493) [Chore][libbeat] Replace global logger with single logger instance #2 #44687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…43493) * [Chore] Use single logger instance * Update x-pack/filebeat/fbreceiver/receiver_test.go Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> * Update x-pack/filebeat/fbreceiver/receiver_test.go Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> * libbeat/cmd is complete * keep only libbeat changes * keep only libbeat changes * add libbeat/monitoring/report package * add my fork * use beat.Info.Logger * remove cloudid * remove println * fix tests * add libbeat/idxmgmt * add libbeat/monitoring/report * go mod tidy * fix idxmgmt tests * fixing and finishing things * fix tests * fix tests * fix tests * debugging statement * stringify debug statement * fixing tests * fixing tests * add libbeat/instrumentation * update ea-libs * fix lint * fix tests and lint * golangci lint * initialize logger before using in instrumentation * address review comments * address review comments 2 * add libbeat/output & libbeat/template * fix tests * add libbeat/dashboards & libbeat/cfgfile * add libbeat/dashboards & libbeat/cfgfile * fix lint * add libbeat/persistentcache * mage check * mage check * merge and fix tests * fix test * add logger on metricbeat * fix lint * fix lint * fix tests * address review comments * lint check * fix lint * fix lint * fix lint * fix lint * fix lint * fix lint in redis files * lint fix * fix lint * fix lint and tests * fix logstash test * fix test reload functionality * add integration build tag * use t.TempDir and non-capitalize logged errors * add linter check * fix log discrepancy * add nolint for errors starting with capitalized letter * fix logger discrepancy * add linting fixes --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> (cherry picked from commit 8920a05) # Conflicts: # filebeat/beater/filebeat.go # heartbeat/beater/heartbeat.go # libbeat/autodiscover/autodiscover_test.go # libbeat/cfgfile/reload.go # libbeat/cmd/instance/beat.go # libbeat/outputs/elasticsearch/client_integration_test.go # libbeat/outputs/elasticsearch/client_test.go # libbeat/outputs/logstash/logstash_integration_test.go # metricbeat/beater/metricbeat.go
|
Cherry-pick of 8920a05 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
…43493) * [Chore] Use single logger instance * Update x-pack/filebeat/fbreceiver/receiver_test.go Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> * Update x-pack/filebeat/fbreceiver/receiver_test.go Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> * libbeat/cmd is complete * keep only libbeat changes * keep only libbeat changes * add libbeat/monitoring/report package * add my fork * use beat.Info.Logger * remove cloudid * remove println * fix tests * add libbeat/idxmgmt * add libbeat/monitoring/report * go mod tidy * fix idxmgmt tests * fixing and finishing things * fix tests * fix tests * fix tests * debugging statement * stringify debug statement * fixing tests * fixing tests * add libbeat/instrumentation * update ea-libs * fix lint * fix tests and lint * golangci lint * initialize logger before using in instrumentation * address review comments * address review comments 2 * add libbeat/output & libbeat/template * fix tests * add libbeat/dashboards & libbeat/cfgfile * add libbeat/dashboards & libbeat/cfgfile * fix lint * add libbeat/persistentcache * mage check * mage check * merge and fix tests * fix test * add logger on metricbeat * fix lint * fix lint * fix tests * address review comments * lint check * fix lint * fix lint * fix lint * fix lint * fix lint * fix lint in redis files * lint fix * fix lint * fix lint and tests * fix logstash test * fix test reload functionality * add integration build tag * use t.TempDir and non-capitalize logged errors * add linter check * fix log discrepancy * add nolint for errors starting with capitalized letter * fix logger discrepancy * add linting fixes --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
|
@khushijain21 That's strange, looks like you have a conflict with #40816 missing but I thought we backported it to 8.x branch (that is now 8.19). |
There was another PR that moved that code to |
|
Forgot about it thanks :-) |
|
This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏 |
Proposed commit message
See https://github.com/elastic/ingest-dev/issues/5251
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run this test in
x-pack/filebeat/fbreceivergo test -run ^TestMultipleReceivers$ ./x-pack/filebeat/fbreceiver -vRelated issues
This is an automatic backport of pull request #43493 done by [Mergify](https://mergify.com).