-
Notifications
You must be signed in to change notification settings - Fork 5k
Add NewBeatReceiver function for beats as otel receivers #40816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NewBeatReceiver function for beats as otel receivers #40816
Conversation
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
|
This pull request doesn't have a |
510b9ed to
6fd0fee
Compare
6fd0fee to
e44e465
Compare
e44e465 to
60eaeee
Compare
cmacknz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, thanks! I would like to make sure we have a test that creates a beat receiver with this method eventually, but I also recognize that requires a lot of work we haven't done yet.
* Add NewBeatReceiver function for beats as otel receivers (cherry picked from commit 8feb181)
…0891) * Add NewBeatReceiver function for beats as otel receivers (cherry picked from commit 8feb181) Co-authored-by: Lee E Hinman <[email protected]>
Proposed commit message
This PR adds a new function
NewBeatReceiverto instantiate a beat as an otel receiver. The code is similar to thecreateBeaterandconfigurefunctions. It is separate to so that understanding of tel receivers doesn't leak into to existing Beat setup. This also makes it much safer to change the receiver setup without breaking the traditional beat setup.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
None
Author's Checklist
How to test this PR locally
Integration tests will catch if this change breaks regular beats instantiation. When receivers are added that will test that the new function works correctly.
Related issues
Use cases
Screenshots
Logs