Skip to content

[chore][metricbeat/test_diskio]: fix CI failure #41580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VihasMakwana merged 3 commits into from
Nov 11, 2024
Merged

[chore][metricbeat/test_diskio]: fix CI failure #41580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cda9df
chore: fix CI failure
VihasMakwana Nov 11, 2024
ffa0c53
lint
VihasMakwana Nov 11, 2024
5e8f305
bug
VihasMakwana Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions metricbeat/module/system/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ def test_diskio(self):
if 'error' not in evt:
if "system" in evt:
diskio = evt["system"]["diskio"]
self.remove_fields(diskio, ["serial_number"])
self.assert_fields_for_platform(SYSTEM_DISKIO, diskio)
elif "host" in evt:
host_disk = evt["host"]["disk"]
Expand Down
5 changes: 5 additions & 0 deletions metricbeat/tests/system/metricbeat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ def check_metricset(self, module, metricset, hosts, fields: list = None, extras:

self.assert_fields_are_documented(evt)

def remove_fields(self, event: object, fields: list):
for field in fields:
if field in event:
del event[field]


def supported_versions(path):
"""
Expand Down