-
Notifications
You must be signed in to change notification settings - Fork 5k
[chore][metricbeat/test_diskio]: fix CI failure #41580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
* chore: fix CI failure * lint * bug (cherry picked from commit 56dca4b)
* chore: fix CI failure * lint * bug (cherry picked from commit 56dca4b) Co-authored-by: Vihas Makwana <[email protected]>
* chore: fix CI failure * lint * bug (cherry picked from commit 56dca4b)
* chore: fix CI failure * lint * bug (cherry picked from commit 56dca4b) Co-authored-by: Vihas Makwana <[email protected]>
For
diskiometricset,beats/metricbeat/module/system/diskio/diskio.go
Lines 118 to 120 in bfaa70f
serial_numberfield is set, conditionally.This error has likely originated by bumping PR on https://github.com/elastic/elastic-agent-system-metrics.
I think, for such conditional fields, our best case is to remove them from
eventor else they trigger a failure.We cannot add such fields at
beats/metricbeat/module/system/test_system.py
Lines 70 to 76 in bfaa70f
as that would also result in a failure, because the
serial_numbercan be absent for some devices.This is needed to unblock #41524