Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod - update to go-libaudit v2.6.1 #41558

Merged

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Nov 7, 2024

Proposed commit message

Update to go-libaudit v2.6.1.

This release updates the syscall tables for Linux 6.11. And it corrects the ECS `event.type`
value used for SERVICE_STOP, DAEMON_ABORT, and DAEMON_END messages.

https://github.com/elastic/go-libaudit/releases/tag/v2.6.1

https://github.com/elastic/go-libaudit/compare/v2.5.0..v2.6.1

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 7, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 7, 2024
@andrewkroh andrewkroh force-pushed the auditbeat/feature/update-go-libaudit-2.6 branch from 0b5371f to 7683396 Compare November 7, 2024 20:23
@andrewkroh andrewkroh added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Nov 7, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 7, 2024
@andrewkroh andrewkroh marked this pull request as ready for review November 7, 2024 20:25
@andrewkroh andrewkroh requested a review from a team as a code owner November 7, 2024 20:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@andrewkroh
Copy link
Member Author

Nothing changed in the definition of the USER_ROLE_CHANGE1 normalization, but the tests are failing. I suspect that the change from yaml.v2 -> yaml.v3 in go-libaudit had an effect on the YAML anchor and alias evaluation. I think we need to diff the result of unmarshaling the normalizations.yaml between 2.4.0 and 2.5.0 or yaml.v2 and yaml.v3.

"how": "/bin/su",
"object": {
"primary": "1234",
"secondary": "127.0.0.1",
"type": "user-session"
}
}

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -925,5 +925,4 @@
        	            	     (string) (len=3) "how": (string) (len=7) "/bin/su",
        	            	-    (string) (len=6) "object": (map[string]interface {}) (len=3) {
        	            	+    (string) (len=6) "object": (map[string]interface {}) (len=2) {
        	            	      (string) (len=7) "primary": (string) (len=4) "1234",
        	            	-     (string) (len=9) "secondary": (string) (len=9) "127.0.0.1",
        	            	      (string) (len=4) "type": (string) (len=12) "user-session"
        	Test:       	TestGoldenFiles/sudo
=== FAIL: auditbeat/module/auditd TestGoldenFiles (0.14s)

Footnotes

  1. https://github.com/elastic/go-libaudit/blame/7d76d1d23187e2a3e2dcfabc4d15c8872448af86/aucoalesce/normalizations.yaml#L1087-L1093

@andrewkroh
Copy link
Member Author

The problem is now tracked in elastic/go-libaudit#169.

@andrewkroh andrewkroh marked this pull request as draft November 8, 2024 00:24
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Nov 8, 2024
@andrewkroh andrewkroh force-pushed the auditbeat/feature/update-go-libaudit-2.6 branch 3 times, most recently from cbc65b8 to 0c8fd75 Compare November 8, 2024 21:20
@andrewkroh andrewkroh force-pushed the auditbeat/feature/update-go-libaudit-2.6 branch from 0c8fd75 to 21397b5 Compare November 22, 2024 15:06
@andrewkroh andrewkroh changed the title go.mod - update to go-libaudit v2.6.0 go.mod - update to go-libaudit v2.6.1 Nov 22, 2024
@elastic elastic deleted a comment from mergify bot Nov 22, 2024
@andrewkroh
Copy link
Member Author

The problem was fixed upstream in go-libaudit v2.6.1, and the PR has be updated to use that version.

@andrewkroh andrewkroh marked this pull request as ready for review November 22, 2024 15:55
@andrewkroh andrewkroh requested a review from a team November 22, 2024 16:07
@andrewkroh andrewkroh merged commit e7225b6 into elastic:main Nov 22, 2024
142 checks passed
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
Update to go-libaudit v2.6.1.

This release updates the syscall tables for Linux 6.11. And it corrects the ECS `event.type`
value used for SERVICE_STOP, DAEMON_ABORT, and DAEMON_END messages.

https://github.com/elastic/go-libaudit/releases/tag/v2.6.1
(cherry picked from commit e7225b6)
pierrehilbert pushed a commit that referenced this pull request Nov 25, 2024
Update to go-libaudit v2.6.1.

This release updates the syscall tables for Linux 6.11. And it corrects the ECS `event.type`
value used for SERVICE_STOP, DAEMON_ABORT, and DAEMON_END messages.

https://github.com/elastic/go-libaudit/releases/tag/v2.6.1
(cherry picked from commit e7225b6)

Co-authored-by: Andrew Kroh <[email protected]>
Kavindu-Dodan pushed a commit to Kavindu-Dodan/beats that referenced this pull request Nov 27, 2024
Update to go-libaudit v2.6.1.

This release updates the syscall tables for Linux 6.11. And it corrects the ECS `event.type`
value used for SERVICE_STOP, DAEMON_ABORT, and DAEMON_END messages.

https://github.com/elastic/go-libaudit/releases/tag/v2.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat backport-8.x Automated backport to the 8.x branch with mergify Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants