Skip to content

[8.x](backport #41365) Remove DEV=true for snapshot packaging #41374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rdner merged 1 commit into from
Oct 22, 2024
Merged

[8.x](backport #41365) Remove DEV=true for snapshot packaging #41374

rdner merged 1 commit into from
Oct 22, 2024

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 22, 2024 •
edited by zube bot
Loading

Packaging with DEV=true adds additional Go flags that sometimes lead to linker failures using the old versions of ld.gold.

Closes #41270

This is an automatic backport of pull request #41365 done by Mergify.

@rdner @mergify
Remove DEV=true for snapshot packaging (#41365)
7f1e0a1 
Packaging with `DEV=true` adds additional Go flags that sometimes lead
to linker failures using the old versions of `ld.gold`.

See #41270

(cherry picked from commit af46682)
@mergify mergify bot requested a review from a team as a code owner October 22, 2024 16:13
@mergify mergify bot added the backport label Oct 22, 2024
@mergify mergify bot assigned rdner Oct 22, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 22, 2024
@botelastic
Copy link

botelastic bot commented Oct 22, 2024

This pull request doesn't have a Team:<team> label.

@rdner rdner enabled auto-merge (squash) October 22, 2024 16:16
@rdner rdner merged commit 3c4c8bf into 8.x Oct 22, 2024
@rdner rdner deleted the mergify/bp/8.x/pr-41365 branch October 22, 2024 16:26
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner rdner approved these changes

Assignees

@rdner rdner

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rdner