Skip to content

Remove DEV=true for snapshot packaging #41365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rdner merged 2 commits into from
Oct 22, 2024
Merged

Remove DEV=true for snapshot packaging #41365

rdner merged 2 commits into from
Oct 22, 2024

Conversation

@rdner
Copy link
Member

@rdner rdner commented Oct 22, 2024 •
edited
Loading

Packaging with DEV=true adds additional Go flags that sometimes lead to linker failures using the old versions of ld.gold.

Closes #41270

@rdner
Remove DEV=true for snapshot packaging
a50d736 
Packaging with `DEV=true` adds additional Go flags that sometimes lead
to linker failures using the old versions of `ld.gold`.

See elastic#41270
@rdner rdner added Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Oct 22, 2024
@rdner rdner self-assigned this Oct 22, 2024
@rdner rdner requested a review from a team as a code owner October 22, 2024 13:08
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 22, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 22, 2024

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 22, 2024
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @rdner? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 22, 2024
@rdner rdner mentioned this pull request Oct 22, 2024
Closed
@rdner rdner requested a review from cmacknz October 22, 2024 13:33
mauri870
mauri870 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmacknz
cmacknz reviewed Oct 22, 2024
View reviewed changes
@rdner rdner enabled auto-merge (squash) October 22, 2024 15:47
@rdner rdner merged commit af46682 into elastic:main Oct 22, 2024
@rdner rdner deleted the remove-dev-packaging branch October 22, 2024 16:11
mergify bot pushed a commit that referenced this pull request Oct 22, 2024
@rdner @mergify
Remove DEV=true for snapshot packaging (#41365)
7f1e0a1 
Packaging with `DEV=true` adds additional Go flags that sometimes lead
to linker failures using the old versions of `ld.gold`.

See #41270

(cherry picked from commit af46682)
@mergify mergify bot mentioned this pull request Oct 22, 2024
Merged
rdner added a commit that referenced this pull request Oct 22, 2024
@mergify @rdner
Remove DEV=true for snapshot packaging (#41365) (#41374)
3c4c8bf 
Packaging with `DEV=true` adds additional Go flags that sometimes lead
to linker failures using the old versions of `ld.gold`.

See #41270

(cherry picked from commit af46682)

Co-authored-by: Denis <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz approved these changes

@mauri870 mauri870 mauri870 approved these changes

+1 more reviewer

@alexsapran alexsapran alexsapran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rdner rdner

Labels

backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Agentbeat packaging failures: aarch64-linux-gnu/bin/ld.gold: internal error in maybe_apply_stub, at ../../gold/aarch64.cc:5407

5 participants

@rdner @elasticmachine @alexsapran @cmacknz @mauri870