Skip to content

Docs: update Docker setup commands to remove container when done#41079

Merged
rdner merged 1 commit intomainfrom
doc-conatiner-setup
Oct 7, 2024
Merged

Docs: update Docker setup commands to remove container when done#41079
rdner merged 1 commit intomainfrom
doc-conatiner-setup

Conversation

@mmahacek
Copy link
Contributor

@mmahacek mmahacek commented Oct 2, 2024

Proposed commit message

Add --rm to the setup command to automatically remove the container used to setup. This prevents leaving behind a single-use container instance.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

No, docs only

@mmahacek mmahacek added docs Team:Docs Label for the Observability docs team hacktoberfest-accepted backport-8.x Automated backport to the 8.x branch with mergify labels Oct 2, 2024
@mmahacek mmahacek self-assigned this Oct 2, 2024
@mmahacek mmahacek requested a review from a team as a code owner October 2, 2024 15:38
@mmahacek mmahacek requested review from faec and rdner October 2, 2024 15:38
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 2, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 3, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 3, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@rdner rdner merged commit 9b9d916 into main Oct 7, 2024
@rdner rdner deleted the doc-conatiner-setup branch October 7, 2024 13:37
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
@mmahacek @mergify
Docs: update Docker setup commands to remove container when done (#41079
2984aa5 
)

(cherry picked from commit 9b9d916)
@mergify mergify bot mentioned this pull request Oct 7, 2024
Merged
3 tasks
pierrehilbert pushed a commit that referenced this pull request Oct 7, 2024
@mergify @mmahacek
Docs: update Docker setup commands to remove container when done (#41079
92444a5 
) (#41148)

(cherry picked from commit 9b9d916)

Co-authored-by: mmahacek <mark.mahacek@elastic.co>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner rdner approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@mmahacek mmahacek

Labels

backport-8.x Automated backport to the 8.x branch with mergify docs hacktoberfest-accepted Team:Docs Label for the Observability docs team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmahacek @elasticmachine @rdner @pierrehilbert