[8.x](backport #40885) libbeat: improve BenchmarkExecHttpRequest with multiple sizes#41062
Merged
[8.x](backport #40885) libbeat: improve BenchmarkExecHttpRequest with multiple sizes#41062
Conversation
This benchmark uses a hardcoded Hello World response. In a real world scenario responses will range in size, specifically for _bulk responses. Updated the benchmark to consider different sizes when benchmarking this function. (cherry picked from commit ee157de)
|
This pull request doesn't have a |
mauri870
approved these changes
Oct 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This benchmark uses a hardcoded Hello World response. In a real world scenario responses will range in size, specifically for _bulk responses. Updated the benchmark to consider different sizes when benchmarking this function.
go test -benchmem -run=^$ -tags integration,unit -bench ^BenchmarkExecHTTPRequest$ github.com/elastic/beats/v7/libbeat/esleg/eslegclient -v -count=1
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
This is an automatic backport of pull request libbeat: improve BenchmarkExecHttpRequest with multiple sizes #40885 done by Mergify.