libbeat: improve BenchmarkExecHttpRequest with multiple sizes #40885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauri870
added
cleanup
Team:Elastic-Agent-Data-Plane
botelastic
bot
added
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
mergify
bot
added
the
backport-8.x
mauri870
force-pushed
the
benchmark-exec-http-request
branch
from
1ab0ed2 to
b4ffcfe
Compare
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This benchmark uses a hardcoded Hello World response. In a real world scenario responses will range in size, specifically for _bulk responses. Updated the benchmark to consider different sizes when benchmarking this function.
mauri870
force-pushed
the
benchmark-exec-http-request
branch
from
b4ffcfe to
b3fe46b
Compare
pierrehilbert
requested review from
belimawr
and removed request for
khushijain21
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
This benchmark uses a hardcoded Hello World response. In a real world scenario responses will range in size, specifically for _bulk responses. Updated the benchmark to consider different sizes when benchmarking this function. (cherry picked from commit ee157de)
6 tasks
mauri870
added a commit
that referenced
this pull request
Oct 1, 2024
#41062) This benchmark uses a hardcoded Hello World response. In a real world scenario responses will range in size, specifically for _bulk responses. Updated the benchmark to consider different sizes when benchmarking this function. (cherry picked from commit ee157de) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This benchmark uses a hardcoded Hello World response. In a real world scenario responses will range in size, specifically for _bulk responses. Updated the benchmark to consider different sizes when benchmarking this function.
go test -benchmem -run=^$ -tags integration,unit -bench ^BenchmarkExecHTTPRequest$ github.com/elastic/beats/v7/libbeat/esleg/eslegclient -v -count=1
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues