Skip to content

feat: use reexec stub impl when compiling on non-unix systems #41034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kruskall merged 1 commit into from
Oct 1, 2024
Merged

feat: use reexec stub impl when compiling on non-unix systems #41034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libbeat/cmd/instance/beat_reexec_windows.go → libbeat/cmd/instance/beat_reexec_other.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,19 @@
// specific language governing permissions and limitations
// under the License.

//go:build windows
//go:build !unix

package instance

import (
"runtime"

"github.com/elastic/elastic-agent-libs/logp"
)

// doReexec is a noop on Windows, it only logs a message explaining it.
func (b *Beat) doReexec() error {
logger := logp.L().Named("ssl.cert.reloader")
logger.Info("reloading certs/reexecing is not supported on Windows. %s will not restart", b.Info.Beat)
logger.Info("reloading certs/reexecing is not supported on %s. %s will not restart", runtime.GOOS, b.Info.Beat)
return nil
}
2 changes: 1 addition & 1 deletion libbeat/cmd/instance/beat_reexec_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.

//go:build !windows
//go:build unix

package instance

Expand Down