Skip to content

Conversation

@kruskall
Copy link
Member

Proposed commit message

resolve compile errors on non-unix system (mostly wasm) by using
the noop implementation used for windows

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

resolve compile errors on non-unix system (mostly wasm) by using
the noop implementation used for windows
@kruskall kruskall requested a review from a team as a code owner September 28, 2024 01:11
@kruskall kruskall requested review from faec and leehinman September 28, 2024 01:11
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 28, 2024
@kruskall kruskall changed the title feat: use stub impl when compiling on non-unix systems feat: use reexec stub impl when compiling on non-unix systems Sep 28, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 28, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 29, 2024
@kruskall kruskall merged commit aba8357 into elastic:main Oct 1, 2024
@kruskall kruskall deleted the feat/reexec-compat branch October 1, 2024 17:15
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
resolve compile errors on non-unix system (mostly wasm) by using
the noop implementation used for windows

(cherry picked from commit aba8357)
pierrehilbert pushed a commit that referenced this pull request Oct 3, 2024
resolve compile errors on non-unix system (mostly wasm) by using
the noop implementation used for windows

(cherry picked from commit aba8357)

Co-authored-by: kruskall <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants