[8.x](backport #40992) Fix nil pointer deref if the file output lacks a path setting.#41030
Merged
pierrehilbert merged 1 commit into8.xfrom Sep 29, 2024
Merged
[8.x](backport #40992) Fix nil pointer deref if the file output lacks a path setting.#41030pierrehilbert merged 1 commit into8.xfrom
path setting.#41030pierrehilbert merged 1 commit into8.xfrom
Conversation
) * fix nil pointer deref if the fileout lacks a path * format * fix tests (cherry picked from commit bdcad10)
mergify
bot
requested review from
AndersonQ and
VihasMakwana
and removed request for
a team
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
pierrehilbert
approved these changes
Sep 29, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fixes a small bug where if the
output.fileconfig is enabled but doesn't have a correctly setpathsetting, thepathFormatString.Run()method will be null, and explode. This sets the default config to have a non-null path format string, and also checks to make sureEventFormatStringis non-null.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.This is an automatic backport of pull request #40992 done by [Mergify](https://mergify.com).