Skip to content

Conversation

@fearful-symmetry
Copy link
Contributor

Proposed commit message

Fixes a small bug where if the output.file config is enabled but doesn't have a correctly set path setting, the pathFormatString.Run() method will be null, and explode. This sets the default config to have a non-null path format string, and also checks to make sure EventFormatString is non-null.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry self-assigned this Sep 25, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner September 25, 2024 17:50
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 25, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 25, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 26, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@fearful-symmetry fearful-symmetry merged commit bdcad10 into elastic:main Sep 27, 2024
mergify bot pushed a commit that referenced this pull request Sep 27, 2024
)

* fix nil pointer deref if the fileout lacks a path

* format

* fix tests

(cherry picked from commit bdcad10)
pierrehilbert pushed a commit that referenced this pull request Sep 29, 2024
) (#41030)

* fix nil pointer deref if the fileout lacks a path

* format

* fix tests

(cherry picked from commit bdcad10)

Co-authored-by: Alex K. <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants