Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

In the existing code, we create a mapstr.M containing attributes to set in the RootFields of metric events, which is reused several times in a loop. In the publisher code, the root fields are modified, e.g. https://github.com/elastic/beats/blob/main/metricbeat/mb/event.go#L79, which causes a panic due to fatal error: concurrent map iteration and map write, as the same mapstr.M object is still being used in later iterations of the loop.

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #40901 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner September 19, 2024 09:18
@mergify mergify bot added the backport label Sep 19, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 19, 2024
@botelastic
Copy link

botelastic bot commented Sep 19, 2024

This pull request doesn't have a Team:<team> label.

@tommyers-elastic tommyers-elastic merged commit ae3fa91 into 8.x Sep 19, 2024
@tommyers-elastic tommyers-elastic deleted the mergify/bp/8.x/pr-40901 branch September 19, 2024 12:12
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants