[metricbeat][panw] fix concurrent map write error caused by reusing a mapstr.M #40901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
shmsr
approved these changes
Sep 19, 2024
shmsr
changed the title
tommyers-elastic
added
the
backport-8.x
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Co-authored-by: dparkerelastic <[email protected]> (cherry picked from commit 26daf71)
6 tasks
tommyers-elastic
added a commit
that referenced
this pull request
Sep 19, 2024
…40903) Co-authored-by: dparkerelastic <[email protected]> (cherry picked from commit 26daf71) Co-authored-by: Tom Myers <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing code, we create a mapstr.M containing attributes to set in the
RootFieldsof metric events, which is reused several times in a loop. In the publisher code, the root fields are modified, e.g. https://github.com/elastic/beats/blob/main/metricbeat/mb/event.go#L79, which causes a panic due tofatal error: concurrent map iteration and map write, as the same mapstr.M object is still being used in later iterations of the loop.Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs