package: docker images to match the unified release format by v1v · Pull Request #30895 · elastic/beats

v1v · 2022-03-17T11:03:58Z

What does this PR do?

Rename docker images from the package system to match the expected naming by the unified release.

Therefore, the new name will end with either docker-image-linux-amd64.tar.gz or docker-image-linux-arm64.tar.gz.

Why is it important?

Simplify the Daily Release Snapshots manipulation -> elastic/apm-server#7530 (comment)

Test

If I run TYPES=docker mage package then

Generated fields.yml for metricbeat to /Users/vmartinez/work/src/github.com/elastic/beats/x-pack/metricbeat/fields.yml
>> Building metricbeat.yml for linux/amd64
>> Building metricbeat.reference.yml for linux/amd64
>> Building metricbeat.docker.yml for linux/amd64
exec: go "list" "-m"
>> buildGoDaemon: Building for linux/arm64
>> golangCrossBuild: Building for linux/arm64
>> buildGoDaemon: Building for linux/386
>> golangCrossBuild: Building for windows/amd64
>> golangCrossBuild: Building for darwin/amd64
>> golangCrossBuild: Building for darwin/arm64
>> golangCrossBuild: Building for linux/amd64
>> golangCrossBuild: Building for windows/386
...
>> Testing package contents
package ran for 6m51.279139761s

Actions

Fix the UTs in the packaging
Look for consumers if any
Update docs/changelog if needed?
Gather feedback from the teams

mergify · 2022-03-17T11:04:36Z

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

elasticmachine · 2022-03-17T12:38:21Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-27T07:43:23.017+0000
Duration: 113 min 57 sec

Test stats 🧪

Test	Results
Failed	0
Passed	22533
Skipped	1937
Total	24470

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

v1v · 2022-03-17T13:17:19Z

/package

see elastic#30895

rdner · 2022-04-07T08:00:36Z

@v1v is this PR still relevant?

jlind23 · 2022-04-13T15:20:07Z

@v1v any update on this?

v1v · 2022-04-18T11:48:40Z

This is still valid

…er-tar-gz * upstream/main: (139 commits) [Automation] Update elastic stack version to 8.3.0-c655cda8 for testing (elastic#31322) Define a queue metrics reporter interface (elastic#31289) [Oracle Module] Change tablespace metricset collection period (elastic#31259) libbeat/reader/syslog: relax timestamp parsing to allow leading zero (elastic#31254) [Automation] Update elastic stack version to 8.3.0-55ba6f37 for testing (elastic#31311) [libbeat] Remove unused fields and functions in the memory queue (elastic#31302) [libbeat] Cleaning up some unneeded helper types (elastic#31290) Readme for kibana module (elastic#31276) [Automation] Update elastic stack version to 8.3.0-4be61f32 for testing (elastic#31296) x-pack/winlogbeat/module/routing/ingest: fix typo for channel name (elastic#31291) Small pipeline cleanup removing some unused data fields (elastic#31288) removing info log (elastic#30971) Simplify TLS config deserialization (elastic#31168) Detect new files under known paths in filestream input (elastic#31268) Add support for port mapping in docker hints (elastic#31243) Update qa-labels.yml (elastic#31260) libbeat: log debug for `proxy_url` and fixed docs (elastic#31130) [heartbeat][docs] Add note about ensuring correct index settings for uptime (elastic#31146) [Automation] Update elastic stack version to 8.3.0-2c8f9574 for testing (elastic#31256) [Filebeat] fix m365_defender pipeline bug (elastic#31227) ...

…fied release

… the unified release" This reverts commit 4635f59.

v1v · 2022-04-18T14:39:01Z

/package

mergify · 2022-04-21T11:01:16Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/rename-docker-tar-gz upstream/feature/rename-docker-tar-gz
git merge upstream/main
git push upstream feature/rename-docker-tar-gz

mdelapenya · 2022-05-01T15:58:23Z

@v1v I guess the e2e will need a change here: https://github.com/elastic/e2e-testing/blob/50f964a93042dcb0b551e6fd0385400be8d3217a/pkg/downloads/versions.go#L358-L366

mergify · 2022-05-04T11:03:25Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/rename-docker-tar-gz upstream/feature/rename-docker-tar-gz
git merge upstream/main
git push upstream feature/rename-docker-tar-gz

v1v · 2022-05-16T12:24:36Z

/package

mergify · 2022-05-18T14:50:12Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/rename-docker-tar-gz upstream/feature/rename-docker-tar-gz
git merge upstream/main
git push upstream feature/rename-docker-tar-gz

mergify · 2022-08-15T14:15:09Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/rename-docker-tar-gz upstream/feature/rename-docker-tar-gz
git merge upstream/main
git push upstream feature/rename-docker-tar-gz

mergify · 2022-09-26T06:35:24Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/rename-docker-tar-gz upstream/feature/rename-docker-tar-gz
git merge upstream/main
git push upstream feature/rename-docker-tar-gz

v1v · 2022-09-26T09:20:00Z

I'll close this issue, and let the DC team drive this change if needed in the future

package: docker images to match the unified release format

3406fc7

botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 17, 2022

mergify Bot assigned v1v Mar 17, 2022

mergify Bot added the backport-skip Skip notification from the automated backport with mergify label Mar 17, 2022

v1v mentioned this pull request Mar 17, 2022

ci: Daily Releasable Artifacts pipeline elastic/apm-server#7530

Merged

v1v added a commit to v1v/beats that referenced this pull request Mar 17, 2022

ci: alternative for the unified release naming

6a6b8f9

see elastic#30895

mtojek added the Team:Automation Label for the Observability productivity team label Mar 21, 2022

botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2022

v1v added 7 commits April 18, 2022 12:51

package: use specific variable for docker images

611a43e

package: filter tests for docker images

cd62288

package: amd64 suffix in the docker tar.gz is not required by the uni…

4635f59

…fied release

Revert "package: amd64 suffix in the docker tar.gz is not required by…

6b93edd

… the unified release" This reverts commit 4635f59.

package: use docker-image-linux

e67a5f3

docs: add changelog entry

79eebd2

Merge branch 'main' into feature/rename-docker-tar-gz

1d97b7f

Merge branch 'main' into feature/rename-docker-tar-gz

0f69f8d

v1v commented May 16, 2022

View reviewed changes

Comment thread CHANGELOG.next.asciidoc

Update CHANGELOG.next.asciidoc

bdbb8d4

v1v mentioned this pull request May 16, 2022

package: rename docker tar.gz packages to docker-image-linux-<arch>.tar.gz #31457

Closed

Merge branch 'main' into feature/rename-docker-tar-gz

1949de4

v1v closed this Sep 26, 2022

Uh oh!

Conversation

v1v commented Mar 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Test

Actions

Uh oh!

mergify Bot commented Mar 17, 2022

Uh oh!

elasticmachine commented Mar 17, 2022 • edited by jenkins-beats-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

Uh oh!

v1v commented Mar 17, 2022

Uh oh!

rdner commented Apr 7, 2022

Uh oh!

jlind23 commented Apr 13, 2022

Uh oh!

v1v commented Apr 18, 2022

Uh oh!

v1v commented Apr 18, 2022

Uh oh!

mergify Bot commented Apr 21, 2022

Uh oh!

mdelapenya commented May 1, 2022

Uh oh!

mergify Bot commented May 4, 2022

Uh oh!

Uh oh!

v1v commented May 16, 2022

Uh oh!

mergify Bot commented May 18, 2022

Uh oh!

mergify Bot commented Aug 15, 2022

Uh oh!

mergify Bot commented Sep 26, 2022

Uh oh!

v1v commented Sep 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

v1v commented Mar 17, 2022 •

edited

Loading

elasticmachine commented Mar 17, 2022 •

edited by jenkins-beats-ci Bot

Loading