removing info log by solrac97gr · Pull Request #30971 · elastic/beats

solrac97gr · 2022-03-23T14:26:01Z

What does this PR do?

Remove the info log, because this were generating unnecessary logs.

Why is it important?

That generate a big number of log who can distract of the real problem.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

Check if it's also convenient just change the info to debug log

How to test this PR locally

check in the watch logs there is not showing the "Start Next Scan" log

Related issues

Closes [Filebeat] Reduce useless console log in filestream input #30394

Use cases

Scenario: Your Watch get a Event
When the Watcher have new Event
Then the Watcher will not create a log with "Start Next Scan" in every event

Screenshots

Logs

cla-checker-service · 2022-03-23T14:26:07Z

💚 CLA has been signed

mergify · 2022-03-23T14:26:16Z

This pull request does not have a backport label. Could you fix it @solrac97gr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

solrac97gr · 2022-03-23T14:31:22Z

I already sign the Licence

elasticmachine · 2022-03-23T14:32:03Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-04-13T13:21:44.718+0000
Duration: 65 min 32 sec

Test stats 🧪

Test	Results
Failed	0
Passed	6200
Skipped	728
Total	6928

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2022-03-30T12:34:11Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

jlind23 · 2022-03-30T12:35:06Z

/test

cmacknz · 2022-03-30T18:19:10Z

I already sign the Licence

@solrac97gr I checked I see the license signed with the hotmail address in your github profile, but the email for the commit is a gmail address. The CLA is looking at the commit email, not the PR. Either signing the CLA with your the gmail address in the commit or changing the commit to use your hotmail address will fix the check.

kvch

Please do not remove this log message. It has helped me on many occasions to track down issues. Instead decrease the log level to debug.

solrac97gr · 2022-03-31T11:32:27Z

@cmacknz changing no problem

…eats into I30394-removing-console-log

* build and packages beats for darwin/arm64. The tar.gz package is called darwin-aarch64 * Osquerybeat: Add darwin/arm64 packaging support (#30935) Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co> removing info log removing info log

…eats into I30394-removing-console-log

This reverts commit aa7065a.

…eats into I30394-removing-console-log

solrac97gr · 2022-03-31T12:09:56Z

already try changing mail and signin with both mails but not result

cmacknz · 2022-04-11T13:50:20Z

already try changing mail and signin with both mails but not result

I had to re-trigger the verification. It is signed now, and the CI checks can continue.

cmacknz · 2022-04-12T12:29:20Z

/test

kvch

WFG

jlind23 · 2022-04-13T13:04:23Z

/test

…er-tar-gz * upstream/main: (139 commits) [Automation] Update elastic stack version to 8.3.0-c655cda8 for testing (elastic#31322) Define a queue metrics reporter interface (elastic#31289) [Oracle Module] Change tablespace metricset collection period (elastic#31259) libbeat/reader/syslog: relax timestamp parsing to allow leading zero (elastic#31254) [Automation] Update elastic stack version to 8.3.0-55ba6f37 for testing (elastic#31311) [libbeat] Remove unused fields and functions in the memory queue (elastic#31302) [libbeat] Cleaning up some unneeded helper types (elastic#31290) Readme for kibana module (elastic#31276) [Automation] Update elastic stack version to 8.3.0-4be61f32 for testing (elastic#31296) x-pack/winlogbeat/module/routing/ingest: fix typo for channel name (elastic#31291) Small pipeline cleanup removing some unused data fields (elastic#31288) removing info log (elastic#30971) Simplify TLS config deserialization (elastic#31168) Detect new files under known paths in filestream input (elastic#31268) Add support for port mapping in docker hints (elastic#31243) Update qa-labels.yml (elastic#31260) libbeat: log debug for `proxy_url` and fixed docs (elastic#31130) [heartbeat][docs] Add note about ensuring correct index settings for uptime (elastic#31146) [Automation] Update elastic stack version to 8.3.0-2c8f9574 for testing (elastic#31256) [Filebeat] fix m365_defender pipeline bug (elastic#31227) ...

Log start of filestream scan at debug level Co-authored-by: carlos97gr <carlosgperu97@gmail.com> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

zhiweiv · 2022-07-07T03:33:46Z

Is it possible backport this change to 7.17? We will stay at 7.17 for a long time.

Log start of filestream scan at debug level Co-authored-by: carlos97gr <carlosgperu97@gmail.com> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co> (cherry picked from commit 5478d73)

cmacknz · 2022-07-07T13:21:18Z

@zhiweiv 7.17 cherry pick is here: #32252, it will be a part of the next 7.17 patch release.

Log start of filestream scan at debug level Co-authored-by: carlos97gr <carlosgperu97@gmail.com> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co> (cherry picked from commit 5478d73) Co-authored-by: Carlos García Rosales <carlosgarcia_97gr@hotmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Log start of filestream scan at debug level Co-authored-by: carlos97gr <carlosgperu97@gmail.com> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

removing info log

aa7065a

botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 23, 2022

mergify Bot assigned solrac97gr Mar 23, 2022

mergify Bot added the backport-skip Skip notification from the automated backport with mergify label Mar 23, 2022

jlind23 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 30, 2022

botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 30, 2022

cmacknz requested a review from kvch March 30, 2022 13:29

jlind23 requested a review from a team March 30, 2022 14:19

kvch suggested changes Mar 31, 2022

View reviewed changes

solrac97gr and others added 9 commits March 31, 2022 14:36

removing info log

c736be4

Merge branch 'I30394-removing-console-log' of github.com:solrac97gr/b…

eb20c5d

…eats into I30394-removing-console-log

Merge branch 'I30394-removing-console-log' of github.com:solrac97gr/b…

d004242

…eats into I30394-removing-console-log

removing info log

b3f83d1

Revert "removing info log"

1a1266b

This reverts commit aa7065a.

Merge branch 'I30394-removing-console-log' of github.com:solrac97gr/b…

dde36eb

…eats into I30394-removing-console-log

Deleting log

ab3db77

Merge branch 'I30394-removing-console-log' of github.com:solrac97gr/b…

95f1817

…eats into I30394-removing-console-log

cmacknz reviewed Apr 11, 2022

View reviewed changes

Comment thread filebeat/input/filestream/fswatch.go

Log start of scan at debug level

13b6609

cmacknz requested a review from kvch April 11, 2022 13:49

cmacknz reviewed Apr 11, 2022

View reviewed changes

Comment thread filebeat/input/filestream/fswatch.go Outdated

cmacknz approved these changes Apr 12, 2022

View reviewed changes

kvch approved these changes Apr 13, 2022

View reviewed changes

cmacknz reviewed Apr 13, 2022

View reviewed changes

Comment thread filebeat/input/filestream/fswatch.go Outdated

Replace space with tab in fswatch.go

f0aa14b

cmacknz merged commit 5478d73 into elastic:main Apr 13, 2022

cmacknz added the backport-7.17 Automated backport to the 7.17 branch with mergify label Jul 7, 2022

mergify Bot mentioned this pull request Jul 7, 2022

[7.17](backport #30971) removing info log #32252

Merged

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023

removing info log (#30971)

c28e4f2

Log start of filestream scan at debug level Co-authored-by: carlos97gr <carlosgperu97@gmail.com> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

Uh oh!

Conversation

solrac97gr commented Mar 23, 2022

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Uh oh!

cla-checker-service Bot commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Mar 23, 2022

Uh oh!

solrac97gr commented Mar 23, 2022

Uh oh!

elasticmachine commented Mar 23, 2022 • edited by jenkins-beats-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

Uh oh!

elasticmachine commented Mar 30, 2022

Uh oh!

jlind23 commented Mar 30, 2022

Uh oh!

cmacknz commented Mar 30, 2022

Uh oh!

kvch left a comment

Choose a reason for hiding this comment

Uh oh!

solrac97gr commented Mar 31, 2022

Uh oh!

solrac97gr commented Mar 31, 2022

Uh oh!

Uh oh!

Uh oh!

cmacknz commented Apr 11, 2022

Uh oh!

cmacknz commented Apr 12, 2022

Uh oh!

kvch left a comment

Choose a reason for hiding this comment

Uh oh!

jlind23 commented Apr 13, 2022

Uh oh!

Uh oh!

zhiweiv commented Jul 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmacknz commented Jul 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cla-checker-service Bot commented Mar 23, 2022 •

edited

Loading

elasticmachine commented Mar 23, 2022 •

edited by jenkins-beats-ci Bot

Loading

zhiweiv commented Jul 7, 2022 •

edited

Loading