Skip to content

[7.17](backport #30694) Fix/change the initialization of management layer#30805

Merged
ph merged 3 commits into7.17from
mergify/bp/7.17/pr-30694
Mar 21, 2022
Merged

[7.17](backport #30694) Fix/change the initialization of management layer#30805
ph merged 3 commits into7.17from
mergify/bp/7.17/pr-30694

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Mar 14, 2022 •
edited by zube Bot
Loading

This is an automatic backport of pull request #30694 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify Bot requested a review from a team as a code owner March 14, 2022 16:22
@mergify mergify Bot added the backport label Mar 14, 2022
@mergify mergify Bot assigned ph Mar 14, 2022
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 14, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 14, 2022 •
edited by jenkins-beats-ci Bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-21T15:22:02.830+0000

  • Duration: 43 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 345
Skipped 7
Total 352

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 16, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Mar 16, 2022

update

✅ Branch has been successfully updated

@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 16, 2022

Fix for metricbeat k8s #30870

@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Mar 17, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/7.17/pr-30694 upstream/mergify/bp/7.17/pr-30694
git merge upstream/7.17
git push upstream mergify/bp/7.17/pr-30694

@ph
Fix/change the initialization of management layer (#30694)
105a641 
* Ensure that libbeat manager is instantiated after the hooks.

This fix an issues on Filebeat that make the start sequence of filebeat
non-deterministic. It was possible that not all the hooks were
configured correctly before the managed was receiving a configuration
from the Elastic Agent.

This causes an inconsistency between the expected configuration state
and the actual running states, this includes the following symptoms:

- Having Filebeat runnings and not sending any data to Elasticsearch
- Having Filebeat partially configured, when only some inputs were
  sending data.
- Missing log from the Filebeat collector
- Having only metricsbeats running and sending logs.

This solves the issues by moving the `Start` and stop `Stop` of the
managed into the beats initialization process, each beats need to be
adjusted to support. This is indeed a breaking changes for beats author,
but the bootstrap process of beats and libbeat cannot easily be
extended to make the change into a unique place.

(cherry picked from commit 4c14f03)
@ph ph force-pushed the mergify/bp/7.17/pr-30694 branch from c7eecb8 to 105a641 Compare March 17, 2022 13:47
@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 18, 2022

/test

@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Mar 21, 2022

This pull request has not been merged yet. Could you please review and merge it @ph? 🙏

@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 21, 2022

@v1v Any reason why this PR is stuck on testing?

@v1v
Copy link
Copy Markdown
Member

v1v commented Mar 21, 2022

/test

@mtojek mtojek added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 21, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 21, 2022

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2022
@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 21, 2022

/test

@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 21, 2022

run elasticsearch-ci/docs

@ph ph merged commit 6e046b7 into 7.17 Mar 21, 2022
@mergify mergify Bot deleted the mergify/bp/7.17/pr-30694 branch March 21, 2022 19:26
@axw axw mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ph ph

Labels

backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elasticmachine @ph @v1v @mtojek