Skip to content

[ResponseOps] New metricsets for Kibana stack monitoring#29899

Merged
fearful-symmetry merged 40 commits intoelastic:mainfrom
chrisronline:rops/monitoring_collection
May 24, 2022
Merged

[ResponseOps] New metricsets for Kibana stack monitoring#29899
fearful-symmetry merged 40 commits intoelastic:mainfrom
chrisronline:rops/monitoring_collection

Conversation

@chrisronline
Copy link
Copy Markdown
Contributor

@chrisronline chrisronline commented Jan 18, 2022

Relates to elastic/kibana#123416
Relates to elastic/kibana#123637

This PR introduces an additional metric sets for Kibana stack monitoring related to a new endpoints added for better observability into Kibana alerting.

@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 18, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 18, 2022

This pull request does not have a backport label. Could you fix it @chrisronline? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify Bot added the backport-skip Skip notification from the automated backport with mergify label Jan 18, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-24T18:29:44.531+0000

  • Duration: 55 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 3539
Skipped 870
Total 4409

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jan 24, 2022
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2022
@sayden sayden self-requested a review January 26, 2022 15:47
Copy link
Copy Markdown
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost there, I just left some comments of files that have been removed without need. I need to check yet the dependencies added to the project, probably they aren't necessary either.

Comment thread metricbeat/module/kibana/actions/_meta/fields.yml
Comment thread metricbeat/module/kibana/rules/_meta/fields.yml
Comment thread metricbeat/module/kibana/rules/data.go
Comment thread metricbeat/modules.d/system.yml
Comment thread metricbeat/modules.d/kibana-xpack.yml.disabled
Comment thread metricbeat/modules.d/elasticsearch-xpack.yml.disabled
@sayden sayden added Feature:Stack Monitoring and removed Team:Integrations Label for the Integrations team labels Jan 31, 2022
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 2, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rops/monitoring_collection upstream/rops/monitoring_collection
git merge upstream/master
git push upstream rops/monitoring_collection

Comment thread metricbeat/module/kibana/cluster_actions/_meta/data.json Outdated
@neptunian
Copy link
Copy Markdown
Contributor

@chrisronline
Copy link
Copy Markdown
Contributor Author

@neptunian I honestly don't know. Happy to update if it's necessary

@chrisronline
Copy link
Copy Markdown
Contributor Author

@fearful-symmetry Okay I fixed up a bit and think it's ready for another pass!

Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from linter errors, mostly looking good, just a few small things.

Comment thread metricbeat/module/kibana/kibana.go Outdated
Comment thread metricbeat/module/kibana/node_rules/data.go Outdated
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 20, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rops/monitoring_collection upstream/rops/monitoring_collection
git merge upstream/main
git push upstream rops/monitoring_collection

@chrisronline
Copy link
Copy Markdown
Contributor Author

@fearful-symmetry CI is green! I think all the linting issues are sorted out

Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the Kibana APIs, but code LGTM.

@chrisronline
Copy link
Copy Markdown
Contributor Author

Screen Shot 2022-05-24 at 10 40 47 AM

@fearful-symmetry Can you merge this for me? I don't know why I don't have access

@fearful-symmetry fearful-symmetry merged commit b75886b into elastic:main May 24, 2022
@chrisronline chrisronline deleted the rops/monitoring_collection branch May 24, 2022 20:04
@chrisronline
Copy link
Copy Markdown
Contributor Author

@fearful-symmetry Thank you!

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* WIP

* Update

* More metrics

* More fields

* Reducing what we need here

* Add actions

* Remove unnecessary imports

* Update based on new routes

* Fix a couple issues

* Bring these back

* Update data.json files

* Add new fields

* PR feedback

* PR feedback

* Fix linting issues

* Much better code

* Update this

* Use variable instead of func

* Fix tests

* PR comments

* Fix lint

* maybe this?

* Fix tests

* Fix integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify Feature:Stack Monitoring Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring Team:Integrations Label for the Integrations team

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

7 participants