Skip to content

Explicitly warns about misconfiguration preventing Filebeat to start …#28667

Merged
francescayeye merged 1 commit intoelastic:7.16from
francescayeye:deprecation-warning-for-aws-s3-input-with-no-source-config-param
Oct 29, 2021
Merged

Explicitly warns about misconfiguration preventing Filebeat to start …#28667
francescayeye merged 1 commit intoelastic:7.16from
francescayeye:deprecation-warning-for-aws-s3-input-with-no-source-config-param

Conversation

@francescayeye
Copy link
Copy Markdown

@francescayeye francescayeye commented Oct 27, 2021

…from v8.0

Enhancement

What does this PR do?

Explicitly warns about misconfiguration preventing Filebeat to start from v8.0

Why is it important?

Warning the users that their setup will break in 8.0 will allow them to plan a migration path

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Relates #28666

Use cases

Screenshots

Logs

2021-10-27T11:05:12.048+0200    WARN    [aws-s3]        awss3/config.go:56      Neither queue_url nor bucket_arn were provided, input aws-s3 will stop.Starting from v8.0 this will prevent Filebeat to start.

@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 109 min 45 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@francescayeye francescayeye added the Team:Integrations Label for the Integrations team label Oct 28, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 28, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2021
@francescayeye francescayeye merged commit b3789b5 into elastic:7.16 Oct 29, 2021
@francescayeye francescayeye added the backport-v8.0.0 Automated backport with mergify label Nov 11, 2021
@mergify mergify Bot mentioned this pull request Nov 11, 2021
Closed
mergify Bot pushed a commit that referenced this pull request Nov 11, 2021
Explicitly warns about misconfiguration preventing Filebeat to start …
5758403 
…from v8.0 (#28667)

(cherry picked from commit b3789b5)

# Conflicts:
#	x-pack/filebeat/input/awss3/config.go
@francescayeye francescayeye removed the backport-v8.0.0 Automated backport with mergify label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@francescayeye francescayeye

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francescayeye @elasticmachine @kaiyan-sheng