not setting queue_url bucket_arn or non_aws_bucket_name returns error#28666
Merged
francescayeye merged 5 commits intoelastic:masterfrom Oct 28, 2021
francescayeye:error-on-misconfigured-aws-s3-input
Merged
not setting queue_url bucket_arn or non_aws_bucket_name returns error#28666francescayeye merged 5 commits intoelastic:masterfrom francescayeye:error-on-misconfigured-aws-s3-input
francescayeye merged 5 commits intoelastic:masterfrom
francescayeye:error-on-misconfigured-aws-s3-input
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @aspacca? 🙏
NOTE: |
1 task
Contributor
kaiyan-sheng
approved these changes
Oct 27, 2021
kaiyan-sheng
approved these changes
Oct 28, 2021
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…elastic#28666) * not setting queue_url bucket_arn or non_aws_bucket_name returns error
francescayeye
pushed a commit
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
What does this PR do?
In case an aws-s3 input has no source param defined in the config (either
queue_url,bucket_arnornon_aws_bucket_name) loading the input will return an error on config validation and stop FilebeatWhy is it important?
Giving a proper blocking failure error message instead of silently fail loading the input will improve troubleshooting issue in the aws s3 input.
The same solution was not possible in 7.x due to loading and validating every filesets existing for a module regardless they were configured or not
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Relates #13911
Requires #27526
Use cases
Screenshots
Logs