Cherry-pick #24107 to 7.x: Add unit tests for harvester.go of input-logfile package#24605
Merged
kvch merged 1 commit intoelastic:7.xfrom Mar 18, 2021
Merged
Cherry-pick #24107 to 7.x: Add unit tests for harvester.go of input-logfile package#24605kvch merged 1 commit intoelastic:7.xfrom
kvch merged 1 commit intoelastic:7.xfrom
Conversation
## What does this PR do? This PR adds unit tests for `readerGroup` and `defaultHarvesterGroup` of the `filestream` input. It also creates a separate error for if a Harvester is already running for a source. ## Why is it important? Test coverage for `harvester.go` is increased from 0% to 98.4%. Overall coverage of `github.com/elastic/beats/v7/filebeat/input/filestream/internal/input-logfile` is increased from 47.4% to 64.8%. (cherry picked from commit 93fdd0a)
kvch
added
[zube]: In Review
backport
Team:Elastic-Agent
botelastic
Bot
added
the
needs_team
Contributor
|
Pinging @elastic/agent (Team:Agent) |
botelastic
Bot
removed
the
needs_team
Contributor
Author
|
jenkins run tests |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24107 to 7.x branch. Original message:
What does this PR do?
This PR adds unit tests for
readerGroupanddefaultHarvesterGroupof thefilestreaminput.It also creates a separate error for if a Harvester is already running for a source.
Why is it important?
Test coverage for
harvester.gois increased from 0% to 98.4%.Overall coverage of
github.com/elastic/beats/v7/filebeat/input/filestream/internal/input-logfileis increased from 47.4% to 64.8%.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.