Add unit tests for harvester.go of input-logfile package#24107
Merged
kvch merged 9 commits intoelastic:masterfrom Mar 10, 2021
Merged
Add unit tests for harvester.go of input-logfile package#24107kvch merged 9 commits intoelastic:masterfrom
kvch merged 9 commits intoelastic:masterfrom
Conversation
botelastic
Bot
added
the
needs_team
Contributor
|
Pinging @elastic/agent (Team:Agent) |
botelastic
Bot
removed
the
needs_team
urso
reviewed
Feb 18, 2021
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kvch
force-pushed
the
test-filebeat-add-filestream-harvestergroup
branch
from
f15a004 to
e901056
Compare
Contributor
Author
|
|
kvch
force-pushed
the
test-filebeat-add-filestream-harvestergroup
branch
from
0feb11f to
9be1c0f
Compare
urso
reviewed
Feb 22, 2021
kvch
force-pushed
the
test-filebeat-add-filestream-harvestergroup
branch
from
b60e3b3 to
c98f50c
Compare
urso
reviewed
Mar 3, 2021
urso
reviewed
Mar 3, 2021
kvch
force-pushed
the
test-filebeat-add-filestream-harvestergroup
branch
from
407d1fd to
16db6e9
Compare
urso
approved these changes
Mar 10, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Mar 16, 2021
…reporting-changes * upstream/master: (23 commits) [Auditbeat] btmp offset check (elastic#24515) Clarify that the Tomcat module is for ingesting access logs (elastic#24543) [Ingest Manager] Move logging defaults to agent (elastic#24535) Update input-http-endpoint.asciidoc (elastic#24490) Fix typo in mqtt input docs (elastic#24509) [Elastic Agent] Add verification check when updating communication to Kibana. (elastic#24489) Refactor use of system.hostfs to fix cgroup metrics (elastic#24334) Add test for close.reader.after_interval to filestream input (elastic#24423) chore(ci): use beat_version instead of PR version (elastic#24446) Add syntax for multiple selector logging (elastic#24207) (elastic#24497) Update Golang to 1.15.9 (elastic#24442) [Elastic Agent] Add the ability to provide custom CA's inside of docker. (elastic#24486) Add tests for encoding settings of filestream input (elastic#24426) [Ingest Manager] Sync on rename on windows (elastic#24504) Port four Harvester tests of log input to filestream in Golang (elastic#24250) [DOCS] Restructure content for SSL settings (elastic#24342) Move example to the correct location in reference docs (elastic#24455) Add unit tests for harvester.go of input-logfile package (elastic#24107) Fix type for uwsgi.status.worker.rss field (elastic#24468) [Ingest Manager] Logging to file disabled on enroll (elastic#24466) ...
kvch
added a commit
to kvch/beats
that referenced
this pull request
Mar 17, 2021
## What does this PR do? This PR adds unit tests for `readerGroup` and `defaultHarvesterGroup` of the `filestream` input. It also creates a separate error for if a Harvester is already running for a source. ## Why is it important? Test coverage for `harvester.go` is increased from 0% to 98.4%. Overall coverage of `github.com/elastic/beats/v7/filebeat/input/filestream/internal/input-logfile` is increased from 47.4% to 64.8%. (cherry picked from commit 93fdd0a)
3 tasks
kvch
added
v7.13.0
and removed
needs_backport
kvch
added a commit
that referenced
this pull request
Mar 18, 2021
…4605) ## What does this PR do? This PR adds unit tests for `readerGroup` and `defaultHarvesterGroup` of the `filestream` input. It also creates a separate error for if a Harvester is already running for a source. ## Why is it important? Test coverage for `harvester.go` is increased from 0% to 98.4%. Overall coverage of `github.com/elastic/beats/v7/filebeat/input/filestream/internal/input-logfile` is increased from 47.4% to 64.8%. (cherry picked from commit 93fdd0a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds unit tests for
readerGroupanddefaultHarvesterGroupof thefilestreaminput.It also creates a separate error for if a Harvester is already running for a source.
Why is it important?
Test coverage for
harvester.gois increased from 0% to 98.4%.Overall coverage of
github.com/elastic/beats/v7/filebeat/input/filestream/internal/input-logfileis increased from 47.4% to 64.8%.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.