Skip to content

Add regex tests to prometheus collector tests #21228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagwieers wants to merge 2 commits into from
Closed

Add regex tests to prometheus collector tests #21228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c25f7fd
Add regex tests to prometheus collector tests
dagwieers Sep 22, 2020
9439ec2
Fix typo
dagwieers Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion metricbeat/module/prometheus/collector/collector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,29 @@ func TestSkipMetricFamily(t *testing.T) {
}
assert.Equal(t, len(testFamilies)-2, metricsToKeep)

// test with ine include and one exclude
// test with only one regex exclude filter
ms.includeMetrics, _ = p.CompilePatternList(&[]string{""})
ms.excludeMetrics, _ = p.CompilePatternList(&[]string{"^http_request_duration_microseconds_e_in$"})
metricsToKeep = 0
for _, testFamily := range testFamilies {
if !ms.skipFamily(testFamily) {
metricsToKeep++
}
}
assert.Equal(t, len(testFamilies)-1, metricsToKeep)

// test with only one regex exclude filter
ms.includeMetrics, _ = p.CompilePatternList(&[]string{""})
ms.excludeMetrics, _ = p.CompilePatternList(&[]string{"^http_request_duration_microseconds_[a-e]_in$"})
metricsToKeep = 0
for _, testFamily := range testFamilies {
if !ms.skipFamily(testFamily) {
metricsToKeep++
}
}
assert.Equal(t, len(testFamilies)-4, metricsToKeep)

// test with one include and one exclude
ms.includeMetrics, _ = p.CompilePatternList(&[]string{"http_request_duration_microseconds_a_*"})
ms.excludeMetrics, _ = p.CompilePatternList(&[]string{"http_request_duration_microseconds_a_b_*"})
metricsToKeep = 0
Expand Down