Add regex tests to prometheus collector tests#21228
Closed
dagwieers wants to merge 2 commits intoelastic:masterfrom
Closed
Add regex tests to prometheus collector tests#21228dagwieers wants to merge 2 commits intoelastic:masterfrom
dagwieers wants to merge 2 commits intoelastic:masterfrom
Conversation
This adds missing tests.
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
Bot
added
the
needs_team
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
Contributor
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
Bot
removed
the
needs_team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds missing regex-based tests for the prometheus collector module.
Why is it important?
This relates to #16568 (comment)
We have issues with excluding based on regex and this validates that it is working in the code as it should.
We don't know why the metricbeat RPM packages from Elastic are failing to work as documented, but at least here it works :-)
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
go testRelated issues
Use cases
N/A
Screenshots
N/A
Logs
N/A