Skip to content

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 5, 2020

Cherry-pick of PR #18912 to 7.7 branch. Original message:

Type of change: Bug

What does this PR do?

See issue: #17192
It changes the type of the ingress_hostname field since it is not an IP address

Why is it important?

It is causing mapping issues (ingress_hostname is not an IP address): #17192 (comment)

Checklist

  • [x ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Please let me know if I'm missing something here and I should have done anything else.

Related issues

Other types seem fishy too (should be IPs?), please let me know if you want these to be fixed too in this PR:

    - name: external_ip
      type: keyword
      description: Service external IP
    - name: load_balancer_ip
      type: keyword
      description: Load Balancer service IP
    - name: ingress_ip
      type: keyword
      description: Ingress IP

Logs

See: #17192 (comment)

{
  "type":"mapper_parsing_exception",
  "reason":"failed to parse field [kubernetes.service.ingress_hostname] of type [ip] in document with id 'abc123'. Preview of field's value: 'xyz123.elb.us-west-2.amazonaws.com'",
  "caused_by":{
    "type":"illegal_argument_exception",
    "reason":"'xyz123.elb.us-west-2.amazonaws.com' is not an IP string literal."
  }
}

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 5, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Jun 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2020
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good

@kaiyan-sheng kaiyan-sheng merged commit 3799cfa into elastic:7.7 Jun 5, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_18912_7.7 branch June 5, 2020 22:36
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…astic#19011)

* Fixing type of ingress_hostname (elastic#18912)

(cherry picked from commit 51bc252)

Co-authored-by: Jonatan Ivanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport review Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants