Cherry-pick #18912 to 7.7: Fixing type of ingress_hostname #19011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18912 to 7.7 branch. Original message:
Type of change: Bug
What does this PR do?
See issue: #17192
It changes the type of the
ingress_hostnamefield since it is not an IP addressWhy is it important?
It is causing mapping issues (
ingress_hostnameis not an IP address): #17192 (comment)Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Please let me know if I'm missing something here and I should have done anything else.
Related issues
Other types seem fishy too (should be IPs?), please let me know if you want these to be fixed too in this PR:
Logs
See: #17192 (comment)