Fixing type of ingress_hostname #18912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see issue: elastic#17192
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
|
💚 CLA has been signed |
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Contributor
|
Thank you for fixing this! Could you sign the CLA and also run |
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
kaiyan-sheng
added
needs_backport
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
Contributor
Author
|
@kaiyan-sheng I've already done that right after the bot notified me. Is it possible to rerun the check or did I messed something up? |
Contributor
Author
|
Oh wait: #18912 (comment) and the check is passed. :) |
Member
|
jenkins run the tests please |
Member
|
@jonatan-ivanov could you please update this branch with master? Metricbeat tests are failing because of an issue that has been already solved. |
Contributor
Author
|
@jsoriano @kaiyan-sheng done |
Member
|
ok to test |
Member
|
jenkins run the tests please |
Contributor
Author
|
@kaiyan-sheng @jsoriano Could you please re-run the failing jobs?
|
Member
|
Failure in metricbeat x-pack job should be fixed by #18777, I think this PR would be good to go. |
kaiyan-sheng
approved these changes
Jun 5, 2020
Contributor
|
@jsoriano Great! I will get this merged and cherrypicked. Thank you @jonatan-ivanov! |
kaiyan-sheng
added
v7.9.0
and removed
needs_backport
kaiyan-sheng
added a commit
that referenced
this pull request
Jun 5, 2020
* Fixing type of ingress_hostname (#18912) (cherry picked from commit 824f845) Co-authored-by: Jonatan Ivanov <[email protected]>
kaiyan-sheng
added a commit
that referenced
this pull request
Jun 5, 2020
* Fixing type of ingress_hostname (#18912) (cherry picked from commit 824f845) Co-authored-by: Jonatan Ivanov <[email protected]>
kaiyan-sheng
added a commit
that referenced
this pull request
Jun 5, 2020
* Fixing type of ingress_hostname (#18912) (cherry picked from commit 824f845) Co-authored-by: Jonatan Ivanov <[email protected]>
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#19011) * Fixing type of ingress_hostname (elastic#18912) (cherry picked from commit 51bc252) Co-authored-by: Jonatan Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: Bug
What does this PR do?
See issue: #17192
It changes the type of the
ingress_hostnamefield since it is not an IP addressWhy is it important?
It is causing mapping issues (
ingress_hostnameis not an IP address): #17192 (comment)Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Please let me know if I'm missing something here and I should have done anything else.
Related issues
Other types seem fishy too (should be IPs?), please let me know if you want these to be fixed too in this PR:
Logs
See: #17192 (comment)