Skip to content

Update version when bulk param is available in ES stats API #18459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ycombinator merged 2 commits into from
May 15, 2020
Merged

Update version when bulk param is available in ES stats API #18459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
600dfbc
Update version when bulk param is available in ES stats API
ycombinator May 12, 2020
ffcaa5f
Updating unit tests
ycombinator May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metricbeat/module/elasticsearch/elasticsearch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ var CCRStatsAPIAvailableVersion = common.MustNewVersion("6.5.0")
var EnrichStatsAPIAvailableVersion = common.MustNewVersion("7.5.0")

// BulkStatsAvailableVersion is the version since when bulk indexing stats are available
var BulkStatsAvailableVersion = common.MustNewVersion("7.8.0")
var BulkStatsAvailableVersion = common.MustNewVersion("8.0.0")

// Global clusterIdCache. Assumption is that the same node id never can belong to a different cluster id.
var clusterIDCache = map[string]string{}
Expand Down
4 changes: 2 additions & 2 deletions metricbeat/module/elasticsearch/index/index_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func TestGetServiceURI(t *testing.T) {
expectedPath: statsPath,
},
"bulk_stats_available": {
esVersion: common.MustNewVersion("7.8.0"),
esVersion: common.MustNewVersion("8.0.0"),
expectedPath: strings.Replace(statsPath, statsMetrics, statsMetrics+",bulk", 1),
},
}
Expand All @@ -58,7 +58,7 @@ func TestGetServiceURIMultipleCalls(t *testing.T) {
var uri string
var err error
for i := uint(0); i < numCalls; i++ {
uri, err = getServicePath(*common.MustNewVersion("7.8.0"))
uri, err = getServicePath(*common.MustNewVersion("8.0.0"))
if err != nil {
return false
}
Expand Down